Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FvwmButtons example #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FvwmButtons example #42

wants to merge 1 commit into from

Conversation

rasatpc
Copy link
Contributor

@rasatpc rasatpc commented May 6, 2024

A multitask FvwmButtons configuration.

This is not a PR but shows one example of an advanced FvwmButtons configuration that could be included in /Wiki /Modules /FvwmButtons page.

For my information, what is "Active Buttons"? The example for "Action", I copied it from Arch Linux wiki.

@rasatpc
Copy link
Contributor Author

rasatpc commented May 8, 2024

The example can be made smaller.

For the Icon panel, use SimpleButtons
/Wiki /Panels /SimpleButtons

Comment on lines 122 to 123
*SimpleButton: (1x1, Icon icons/thunar.png, \
Action(Mouse 1) "Exec exec thunar")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this -- where is this configuration for SimpleButton defined?

Copy link
Contributor Author

@rasatpc rasatpc May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My type error and confusing. I updated the icon panel with /Wiki /Panels /SimpleButtons plus a few changes. This is a PR. The "Action Buttons" description is still missing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to the text where this "Active Buttons" phrase is being used, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is one of the head titles on the FvwmButtons page:
https://www.fvwm.org/Wiki/Modules/FvwmButtons/

@somiaj
Copy link
Contributor

somiaj commented May 11, 2024

I personally think examples should be more functional panels, and this page should more describe how layouts and various things work in more detail. This page needs a lot of work, but what you have added would be better as another https://www.fvwm.org/Wiki/Panels/ example.

My suggestion is to move your example to the Panels page, and flesh it out a little bit, describe how you layout the buttons, what the example does, and how it works.

@rasatpc
Copy link
Contributor Author

rasatpc commented May 12, 2024

Can we call it "MultiPanel" or something similar?

@somiaj
Copy link
Contributor

somiaj commented May 12, 2024

Think about the point of the example, if the point is to show how containers or panels work, focus on just that, don't include all the pager and other stuff.

If the point is to show case a panel you use, share the full panel.

You can call it what you want, but MultiPanel doesn't really describe the current example, which seems to be a mix between showing how panels work and showing how to put other things into a panel.

@rasatpc
Copy link
Contributor Author

rasatpc commented May 18, 2024

To show how containers or panels work, focus on just that

I was searching if wiki has any page or reference about Container. If not, it is good to add one example in /Wiki/Panels/ example panels list.

@rasatpc
Copy link
Contributor Author

rasatpc commented May 20, 2024

This PR I will change.

A multitask FvwmButtons configuration.

FvwmButtons correction

FvwmButtons - Active and Action

FvwmButtons description, Active and Action buttons.
@rasatpc
Copy link
Contributor Author

rasatpc commented May 25, 2024

I made a major change to this PR according to the headers: Active Buttons and Actions. It is an interesting page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants