Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWMH Events: more _NET_WM_STATE client messages #1012

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

Zirias
Copy link
Contributor

@Zirias Zirias commented Apr 14, 2024

Handle client messages for modifying _NET_WM_STATE_SKIP_PAGER and _NET_WM_STATE_SKIP_TASKBAR on mapped windows: Update the window property and broadcast the change for modules.

Both are mapped to the single skip-window-list property, so handling both client messages does exactly the same. A client trying to enable one and disable the other one will get the result of the last client message sent.

Fixes #1011

Handle client messages for modifying _NET_WM_STATE_SKIP_PAGER and
_NET_WM_STATE_SKIP_TASKBAR on mapped windows: Update the window property
and broadcast the change for modules.

Both are mapped to the single skip-window-list property, so handling
both client messages does exactly the same. A client trying to enable
one and disable the other one will get the result of the last client
message sent.

Fixes fvwmorg#1011
@ThomasAdam ThomasAdam self-assigned this Apr 14, 2024
@ThomasAdam ThomasAdam self-requested a review April 14, 2024 19:37
@ThomasAdam ThomasAdam added type:enhancement Augmenting an existing feature relates:ewmh Issues is in EWMH/ICCCM2 handling code labels Apr 14, 2024
@ThomasAdam ThomasAdam added this to the 1.1.1 milestone Apr 14, 2024
@ThomasAdam
Copy link
Member

@Zirias

Lovely -- I appreciate there's a little bit of repetition, but that's due to the existing code, and nothing you're introducing.

All looks good to me. Will merge.

@ThomasAdam ThomasAdam merged commit 582c453 into fvwmorg:main Apr 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates:ewmh Issues is in EWMH/ICCCM2 handling code type:enhancement Augmenting an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Handle _NET_WM_STATE_SKIP_TASKBAR in _NET_WM_STATE client messages
2 participants