Heads up: find in project is showing incomplete/incorrect results in 1.18.0 beta

[sbromberger]

Hi,

Please ref: atom/find-and-replace#896, specifically atom/find-and-replace#896 (comment).

Summary is that "Find in Project" results are not correct when this theme (version 0.20.6) is enabled. Switching themes resolves the issue.

(I realize that beta support may be spotty, but I figure I'd give you a heads up anyway.)

This is on OSX 10.12.4.

[sbromberger]

Possibly related to #67?

[DanFreed]

I can confirm this behavior as well. It looks like it is an "off by one" issue. It always shows 1 less line in the results than there actually are.

[swrobel]

I'm seeing it as well in 1.17.2

[DanFreed]

Anyone know how to patch the theme at least temporarily until an actual fix is released?

[TheTourer]

Getting this as well. Troublingly, when there's only a single result per file, nothing shows at all, making the view effectively useless—can't action on anything that would open the file.

[fv0]

@DanFreed: Anyone know how to patch the theme at least temporarily until an actual fix is released?

You can edit the theme and comment out the project-find-results.less file in index.less. This will put it back to its default state. I’m working on a fix at the moment though.

[sbromberger]

Thank you, @fv0! testing now.

[TheTourer]

Works again! Thanks so much @fv0; this theme makes Atom look like it should on macOS. It's the gold standard for native themes.