-
Notifications
You must be signed in to change notification settings - Fork 0
[FA-32] Implement Dockerfile #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scott-clare1
wants to merge
11
commits into
main
Choose a base branch
from
FA-32-implement-dockerfile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samgwd
approved these changes
Apr 7, 2025
Christopher-Norman
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Dockerfile
for the server to make running the server more consistent.What
A
Dockerfile
to run the server.An entry point for consistently running the server, i.e., it is now runnable as a command line script, e.g.,
uv run agent-uno
Why
To remove any issues different devices or missing installations and to make it more of a production solution.
How
With a Dockerfile.
Extra
I had to refactor the project so that
agent_uno
now sits undersrc
this is needed for identifying the project as a command line script.If new dependencies are introduced to the project, please list them here:
click
a command line tool.Checklist
Please ensure you have done the following:
Type of change
Make sure to update label on right hand panel.
MacOS tests
To trigger the CI to run on a macOS backed workflow, add the
macos-ci-test
label to the pull request (PR).Our advice is to only run this workflow when testing the compatability between operating systems for a change that you've made, e.g., adding a new dependency to the virtual environment.