Skip to content

Commit ac03ebb

Browse files
purdeaandreizvecrtzarc
authored and
Lorenzo Castoldi
committed
Don't print error message when there are no row pins and no col pins (qmk#20104)
* Don't print error message when there are no row pins and no col pins This error message could be triggered for example if MATRIX_IO_DELAY is configured in config.h, but the matrix is a custom one. The custom matrix can still call back to existing delay functions that make use of the MATRIX_IO_DELAY macro. In this case 'matrix_pins' in info_data will be true, but there will be no 'direct' 'cols' or 'rows' in info_data['matrix_pins'], and without this commit it would trigger an invalid error. * Update lib/python/qmk/info.py Co-authored-by: Nick Brassel <nick@tzarc.org> --------- Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Nick Brassel <nick@tzarc.org>
1 parent 6869845 commit ac03ebb

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

lib/python/qmk/info.py

+3
Original file line numberDiff line numberDiff line change
@@ -743,6 +743,9 @@ def _check_matrix(info_data):
743743
elif 'cols' in info_data['matrix_pins'] and 'rows' in info_data['matrix_pins']:
744744
col_count = len(info_data['matrix_pins']['cols'])
745745
row_count = len(info_data['matrix_pins']['rows'])
746+
elif 'cols' not in info_data['matrix_pins'] and 'rows' not in info_data['matrix_pins']:
747+
# This case caters for custom matrix implementations where normal rows/cols are specified
748+
return
746749

747750
if col_count != actual_col_count and col_count != (actual_col_count / 2):
748751
# FIXME: once we can we should detect if split is enabled to do the actual_col_count/2 check.

0 commit comments

Comments
 (0)