Define timeout for vulnerabilities scan and platform detection

[s7anley]

What did you implement:

I added configuration for timeouts inside of scan command, which were hard-coded until now. I came across issue with timeouts for platform detection when testing with servers in Europe.

How did you implement it:

By adding two new flags for scan command.

How can we verify it:

Either try connect to servers in opposite side of world with default configuration or decrease timeouts configuration to see that values are used.

Todos:

You don't have to satisfy all of the following.

• Write tests
• Write documentation
• Check that there aren't other open pull requests for the same issue/feature
• Format your source code by make fmt
• Pass the test by make test
• Provide verification config / commands
• Enable "Allow edits from maintainers" for this PR
• Update the messages below

Is this ready for review?: Yes
Is it a breaking change?: No

[knqyf263]

Change the option names, please.
-timeout → -timeout-scan
-timeout-detect-platform → -timeout

[knqyf263]

-timeout → -timeout-scan

[knqyf263]

-timeout-detect-platform → -timeout

[s7anley]

I'm not sure about this suggestion, since we are in context of Scan, should be -timeout as main option related to it instead of platform detection?

[knqyf263]

I understand what you mean.
However, timeout option is required not only for DetectPlatforms but also for InitServers.
So, we have three choices.

1. -timeout(for scan) , -timeout-detect-platform , -timeout-init-servers
2. -timeout(for scan) , -timeout-except-scan(for DetectPlatforms and InitServers)
3. -timeout(for DetectPlatforms and InitServers), -timeout-scan(for scan)

I think No.3 is good, because InitServers is called in configtest.
It seems to be better to align the option name to -timeout with configtest and scan.

vuls/commands/configtest.go

Line 167 in 33b2aa2

if err := scan.InitServers(); err != nil {

Do you have any other good idea?

[s7anley]

After you summarised it, I guess your are right and options 3 looks good. We should try to minimise number of options to not make CLI to complex and chaotic.

[knqyf263]

Thank you for understanding!
After you fix the option names, I will merge PR!

[s7anley]

Fixed and rebased.

[knqyf263]

Many Thanks!!