-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(os) : support Alma Linux #1261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to test this correctly?
Looking at this log, you are scanning for redhat8.4
. Shouldn't this part be alma8.4
?
[Reboot Required] alma (redhat8.4)
I would like to know more about your test environment, because it is possible that something is wrong with mine.
Maybe, I fixed. Becase it's "alma (alma8.4)".
I installed the latest version of alma. And I updated the kernel with yum, but forgot to reboot. after reboot.
EOL info link : https://wiki.almalinux.org/FAQ.html Below is the latest version of the scan log.
|
* support rocky linux scan * fix miss * lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in assuming that the reason you are changing the processing location of /etc/centos-release
is because AlmaLinux has /etc/centos-release
?
- AlmaLinux 8
[root@1539cb6b9627 ~]# ls /etc/*-release
/etc/almalinux-release /etc/os-release /etc/system-release
/etc/centos-release /etc/redhat-release
[root@1539cb6b9627 ~]# cat /etc/centos-release
AlmaLinux release 8.4 (Electric Cheetah)
[root@1539cb6b9627 ~]# cat /etc/almalinux-release
AlmaLinux release 8.4 (Electric Cheetah)
[root@1539cb6b9627 ~]# cat /etc/redhat-release
AlmaLinux release 8.4 (Electric Cheetah)
- Rocky Linux 8
[root@39f5a7f41777 ~]# ls /etc/*-release
/etc/os-release /etc/redhat-release /etc/rocky-release /etc/system-release
- CentOS 8
[root@b95b419c3937 ~]# ls /etc/*-release
/etc/centos-release /etc/os-release /etc/redhat-release /etc/system-release
/etc/rocky-release
process has been done in two places.
https://github.com/kazuminn/vuls/blob/892ad5c506493b50f7a0eb50da4a92cd59dcd641/scanner/redhatbase.go#L44-L84
Isn't it possible to determine Alma Linux in /etc/redhat-release
as well?
https://github.com/kazuminn/vuls/blob/892ad5c506493b50f7a0eb50da4a92cd59dcd641/scanner/redhatbase.go#L134-L164
Also, I would be happy if you could fix this as well.
https://github.com/kazuminn/vuls/blob/892ad5c506493b50f7a0eb50da4a92cd59dcd641/scanner/oracle.go#L14-L15
Thank you for your review.
It worked without changing the location, so I restored it.
I fixed.
I fixed.
everyone happy. Please. Check code. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to add it here?
https://github.com/kazuminn/vuls/blob/2a685d0f95c48030544d91f9c2b1171aca83de72/scanner/serverapi.go#L213-L228
I'm nervous, but I'd like the order of Rocky and Alma to be unique. In other words, Rocky → Alma, or Alma → Rocky.
For example, the following is in the order Rocky → Alma.
https://github.com/kazuminn/vuls/blob/2a685d0f95c48030544d91f9c2b1171aca83de72/constant/constant.go#L20-L24
However, in the following, the order is reversed.
The examples are listed here. These are not all of them, so please search carefully.
- https://github.com/kazuminn/vuls/blob/2a685d0f95c48030544d91f9c2b1171aca83de72/oval/redhat.go#L17
- https://github.com/kazuminn/vuls/blob/2a685d0f95c48030544d91f9c2b1171aca83de72/oval/util.go#L439-L440
Please add support for AlmaLinux to vulsdoc as well.
https://github.com/vulsdoc/vuls
I added.
unified to Alma -> Rocky. I done pullrequest docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What did you implement:
support Alma Linux version 8.4.
https://almalinux.org/
on oval.
Type of change
Please delete options that are not relevant.
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES