Skip to content

Conversation

@jackbayliss
Copy link
Contributor

Changes

  • Adds ext-mbstring to requirements, as we use various mb_ methods & update composer lock
  • Adds --parallel to pint cs-fix
  • Because it's PHP 8.4, we no longer need to wrap new calls in parentheses
  • Adds a few string types to consts
  • Removes an is_string check as strict comparison is used and switches it for ||

Noticed these while poking about!

Setting as draft as may come back, may not.

@ziadoz
Copy link
Contributor

ziadoz commented Oct 9, 2025

Seems fine to merge this to me.

@jackbayliss jackbayliss marked this pull request as ready for review October 9, 2025 09:35
Copy link
Contributor

@weshooper weshooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jackbayliss jackbayliss merged commit 1926418 into fusionspim:main Oct 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants