Skip to content

Commit 4d0fe84

Browse files
ryanofskyfurszy
authored andcommitted
Update walletdb comment after renaming.
Text from bitcoin#11851 (comment) by John Newbery <john@johnnewbery.com>.
1 parent 5c94ffe commit 4d0fe84

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

src/wallet/walletdb.h

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,13 @@
2323
/**
2424
* Overview of wallet database classes:
2525
*
26-
* - BerkeleyEnvironment is an environment in which the database exists (has no analog in dbwrapper.h)
27-
* - WalletDatabase represents a wallet database (similar to CDBWrapper in dbwrapper.h)
28-
* - BerkeleyBatch is a low-level database transaction (similar to CDBBatch in dbwrapper.h)
29-
* - WalletBatch is a modifier object for the wallet, and encapsulates a database
30-
* transaction as well as methods to act on the database (no analog in
31-
* dbwrapper.h)
26+
* - WalletBatch is an abstract modifier object for the wallet database, and encapsulates a database
27+
* batch update as well as methods to act on the database. It should be agnostic to the database implementation.
3228
*
33-
* The latter two are named confusingly, in contrast to what the names BerkeleyBatch
34-
* and WalletBatch suggest they are transient transaction objects and don't
35-
* represent the database itself.
29+
* The following classes are implementation specific:
30+
* - BerkeleyEnvironment is an environment in which the database exists.
31+
* - BerkeleyDatabase represents a wallet database.
32+
* - BerkeleyBatch is a low-level database batch update.
3633
*/
3734

3835
static const bool DEFAULT_FLUSHWALLET = true;
@@ -106,7 +103,7 @@ class CKeyMetadata
106103
};
107104

108105
/** Access to the wallet database.
109-
* This should really be named CWalletDBBatch, as it represents a single transaction at the
106+
* This represents a single transaction at the
110107
* database. It will be committed when the object goes out of scope.
111108
* Optionally (on by default) it will flush to disk as well.
112109
*/

0 commit comments

Comments
 (0)