GUI: Add SPORK_20 check in sendCoins

Author: random-zebra

src/qt/pivx/guitransactionsutils.cpp

@@ -46,6 +46,10 @@ namespace GuiTransactionsUtils {
                 retStr = QString::fromStdString(sendCoinsReturn.commitRes.ToString());
                 informType = CClientUIInterface::MSG_ERROR;
                 break;
+            case WalletModel::SaplingInMaintenance:
+                retStr = parent->translate("Sapling Protocol temporarily in maintenance. Shielded txes not allowed");
+                informType = CClientUIInterface::MSG_ERROR;
+                break;
             case WalletModel::StakingOnlyUnlocked:
                 // Unlock is only need when the coins are send
                 if (!fPrepare) {

src/qt/walletmodel.cpp

@@ -71,6 +71,11 @@ bool WalletModel::isColdStakingNetworkelyEnabled() const
     return !sporkManager.IsSporkActive(SPORK_19_COLDSTAKING_MAINTENANCE);
 }
 
+bool WalletModel::isSaplingInMaintenance() const
+{
+    return sporkManager.IsSporkActive(SPORK_20_SAPLING_MAINTENANCE);
+}
+
 bool WalletModel::isStakingStatusActive() const
 {
     return wallet && wallet->pStakerStatus && wallet->pStakerStatus->IsActive();
@@ -458,14 +463,17 @@ WalletModel::SendCoinsReturn WalletModel::sendCoins(WalletModelTransaction& tran
     bool fSaplingActive = Params().GetConsensus().NetworkUpgradeActive(cachedNumBlocks, Consensus::UPGRADE_V5_DUMMY);
 
     // Double check tx before do anything
+    CWalletTx* newTx = transaction.getTransaction();
+    if (newTx->IsShieldedTx() && isSaplingInMaintenance()) {
+        return SaplingInMaintenance;
+    }
     CValidationState state;
-    if (!CheckTransaction(*transaction.getTransaction(), true, true, state, true, fColdStakingActive, fSaplingActive)) {
+    if (!CheckTransaction(*newTx, true, true, state, true, fColdStakingActive, fSaplingActive)) {
         return TransactionCheckFailed;
     }
 
     {
         LOCK2(cs_main, wallet->cs_wallet);
-        CWalletTx* newTx = transaction.getTransaction();
         QList<SendCoinsRecipient> recipients = transaction.getRecipients();
 
         // Store PaymentRequests in wtx.vOrderForm in wallet.

src/qt/walletmodel.h

@@ -129,6 +129,7 @@ class WalletModel : public QObject
         TransactionCreationFailed,
         TransactionCheckFailed,
         TransactionCommitFailed,
+        SaplingInMaintenance,
         StakingOnlyUnlocked,
         InsaneFee,
         CannotCreateInternalAddress
@@ -150,6 +151,7 @@ class WalletModel : public QObject
     bool isRegTestNetwork() const;
     /** Whether cold staking is enabled or disabled in the network **/
     bool isColdStakingNetworkelyEnabled() const;
+    bool isSaplingInMaintenance() const;
     CAmount getMinColdStakingAmount() const;
     /* current staking status from the miner thread **/
     bool isStakingStatusActive() const;