Merge bitcoin#2530: [GUI][BUG] remove duplicated coll. confirmation check in MNModel::data

f0fd8ac Refactor: remove duplicated coll. confirmation check in MNModel::data (random-zebra)

Pull request description:

  Follow up to the discussion in bitcoin#2529.
  If walletModel is null, then `MNModel::data` returns true at `WAS_COLLATERAL_ACCEPTED`.
  Fix the bug removing the duplicated check (`getWalletTxDepth > MasternodeCollateralMinConf()` is already checked every 30 seconds in `MNModel::updateMNList`).

ACKs for top commit:
  furszy:
    utACK f0fd8ac
  Fuzzbawls:
    utACK f0fd8ac

Tree-SHA512: 63065b4ae40403107d738d25ebf6616e99df4373b5fbe4d6b924fecddeef4189f455a91e1cbb48e8c85458481ab519420b49210d6e9f5284c6f35c6e53b35d4e

Author: Fuzzbawls

src/qt/pivx/mnmodel.cpp

@@ -106,12 +106,7 @@ QVariant MNModel::data(const QModelIndex &index, int role) const
                 return "Not available";
             }
             case WAS_COLLATERAL_ACCEPTED:{
-                if (!isAvailable) return false;
-                std::string txHash = rec->vin.prevout.hash.GetHex();
-                if (!collateralTxAccepted.value(txHash) && walletModel) {
-                    return walletModel->getWalletTxDepth(rec->vin.prevout.hash) > 0;
-                }
-                return true;
+                return isAvailable && collateralTxAccepted.value(rec->vin.prevout.hash.GetHex());
             }
         }
     }