Doc: @control-whois-storage `--store-whois`

[spirillen]

This part of the documentation is rather unclear about what is stored or not.

part: https://github.com/funilrys/PyFunceble/blob/control-whois-storage/docs/usage/from-a-terminal.rst#--store-whois

If you keeps --store-whois as False is the bare minimum like dates(created,changed,expired), dns, who? stored

If --store-whois = true are you then keeping the complete whois print inclusing all the data you could template from .TLD

[funilrys]

@spirillen I think I forgot my warning from https://github.com/funilrys/PyFunceble/blob/control-whois-storage/docs/configuration/core.rst#store_whois_record

But yes.

store_whois_record is set by default to False. That means that it will store the expiration date and subject (the system still uses/needs them) but not the full WHOIS record.

If you looked at the new (SQL) database structure, it is the record column of the pyfunceble_whois_record table.

There is indeed room for improvement here 🤔

[spirillen]

Hey @funilrys could you try dump a few sql records of each switches? That might help me in writing the docs to see the full picture by my self.

As you know from our keybase conversation I'm still converting to the new structure, so can't currently put up a test bench

A PS to this one, when I'm looking in the https://github.com/funilrys/PyFunceble/blob/control-whois-storage/docs/components/environment-variables.rst#what-do-we-use-and-why- I'm kind a missing this swicth in the Global settings 😒

[funilrys]

Before migration to SQLAlchemy:

After migration to SQLAlchemy:

Without --store-whois or better said with store_whois_record set to False:
(The missing one is because I removed it from the list to reduce the waiting time while testing other things)

With --store-whois or better said with store_whois_record set to True:

[spirillen]

I believe this issue should have been closed with c199b1d

Can you agree with that @funilrys ?

[funilrys]

Agree.