fix: numpy precision #226
Open
fix: numpy precision #226
+26
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/lags is none
added Value error to prevent running the backtest without features
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Ciao @jhug12, sorry for being late and thanks for the great PR. I merged a few things in the codebase: would you mind rebasing your PR? Also: I see you committed other fixes and improvements (thanks once more 🤗) but I am not sure whether they relate to this PR. I can help you with putting some changes in other pull requests, as they will be easier to review. (I was actually thinking whether we should just map the datatypes that come in and when we perform the conversion just respect those, and raise a warning if they're not F64) |
baggiponte
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225
Summary
Changes precision from float32 to float64 for conversion from polars DataFrame to numpy ndarray