Patrick/add cart page #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-fs
commented
Mar 27, 2020
timjchin
reviewed
Mar 27, 2020
timjchin
reviewed
Mar 27, 2020
src/components/CartItems.tsx
Outdated
| return ( | ||
| <ListGroup> | ||
| { products.map((product, i) => ( | ||
| <ListGroup.Item key={i}> |
There was a problem hiding this comment.
Since this list could get resorted (based on the name sort), the key={i} can lead to weirdness:
https://medium.com/@robinpokorny/index-as-a-key-is-an-anti-pattern-e0349aece318
Might be time to create an ID for each product, or, if the title is unique, then use that.
There was a problem hiding this comment.
I've used product.id - thanks for the link.
timjchin
reviewed
Mar 27, 2020
Hey @van-fs would you please review as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the view/edit cart page. Please see comment thread for a callout/question for review.