Unix socket support broken in 1.9.2

[mlafeldt]

Hey, I've been using grpcurl for a while now. A few days ago, I noticed that I can no longer connect to my gRPC server over Unix domain sockets:

❯ grpcurl -unix -plaintext -authority dummy /tmp/actions.sock list
Failed to dial target host "/tmp/actions.sock": connection error: desc = "transport: error while dialing: dial tcp: address /tmp/actions.sock: missing port in address"

❯ grpcurl -version
grpcurl 1.9.2

Version 1.9.1 works fine, so this problem must have been introduced with the latest release:

❯ ~/Downloads/grpcurl_1.9.1_osx_arm64/grpcurl -unix -plaintext -authority dummy /tmp/actions.sock list
grpc.reflection.v1.ServerReflection
...

[mlafeldt]

Looking at the changelog, #480 might be the culprit, but I'm only speculating.

[stuartcarnie]

I can confirm that reverting #480 resolves the issue

[zhyuri]

I think the change #480 is correct. In fact, with that commit, the network parameter can be removed from BlockingDial along with the -unix option from the CLI.

This is because the grpc-go dialer can handle RFC 3986 compliant URI. Here the network type is resolved as unix if the address has unix as schema.

In the example from @mlafeldt, I believe the following should work in grpcurl 1.9.2. Note that -unix is removed and the proxy address has a schema unix://

grpcurl -plaintext -authority dummy unix:///tmp/actions.sock list

[jhump]

@zhyuri, the changes you propose (and that are in PR #498) are not backwards compatible, so I think are non-starter. It would be better to re-formulate this so it's a backwards-compatible change, in a way that also fixes the -unix flag. I left comments on the PR with more details.

[zhyuri]

@jhump thanks for the review!

I pushed a few commits to the PR to address your comments. I also updated the PR description to reflect the change.