bug #744 [Twig] Fixing a bug where a stringable attribute was converted too late (weaverryan)

This PR was merged into the 2.x branch.

Discussion
----------

[Twig] Fixing a bug where a stringable attribute was converted too late

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Tickets       | Fix #741
| License       | MIT

This caused LiveComponents to try to use the Stringable object in its checksum and to json_encode() the object into the props data, instead of using the final, string value. Basically, we cast to the string earlier.

Commits
-------

276d6923 [Twig] Fixing a bug where a strinagable attribute was converted too late

Author: fullstackdeveloperwebapp

src/TwigComponent/src/ComponentFactory.php

@@ -86,6 +86,7 @@ public function mountFromObject(object $component, array $data, ComponentMetadat
         // ensure remaining data is scalar
         foreach ($data as $key => $value) {
             if ($value instanceof \Stringable) {
+                $data[$key] = (string) $value;
                 continue;
             }
 

src/TwigComponent/tests/Integration/ComponentFactoryTest.php

@@ -100,14 +100,14 @@ public function testExceptionThrownIfUnableToWritePassedDataToPropertyAndIsNotSc
 
     public function testStringableObjectCanBePassedToComponent(): void
     {
-        $attributes = (string) $this->factory()->create('component_a', ['propB' => 'B', 'data-item-id-param' => new class() {
+        $attributes = $this->factory()->create('component_a', ['propB' => 'B', 'data-item-id-param' => new class() {
             public function __toString(): string
             {
                 return 'test';
             }
-        }])->getAttributes();
+        }])->getAttributes()->all();
 
-        self::assertSame(' data-item-id-param="test"', $attributes);
+        self::assertSame(['data-item-id-param' => 'test'], $attributes);
     }
 
     public function testTwigComponentServiceTagMustHaveKey(): void