Close all PDDocument in test

simonsteiner1984 · simonsteiner1984 · commit 63e8425c791e · 2025-10-02T10:13:58.000+01:00
diff --git a/fop-core/src/test/java/org/apache/fop/render/pdf/PDFEncodingTestCase.java b/fop-core/src/test/java/org/apache/fop/render/pdf/PDFEncodingTestCase.java
@@ -166,7 +166,8 @@ private void checkEncoding(byte[] pdf, String[] testPattern)
 
     private static String extractTextFromPDF(byte[] pdfContent) throws IOException {
         PDFTextStripper pdfStripper = new PDFTextStripper();
-        PDDocument pdDoc = Loader.loadPDF(pdfContent);
-        return pdfStripper.getText(pdDoc);
+        try (PDDocument pdDoc = Loader.loadPDF(pdfContent)) {
+            return pdfStripper.getText(pdDoc);
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,8 @@ private void checkEncoding(byte[] pdf, String[] testPattern)`
`166`	`166`
`167`	`167`	`private static String extractTextFromPDF(byte[] pdfContent) throws IOException {`
`168`	`168`	`PDFTextStripper pdfStripper = new PDFTextStripper();`
`169`		`- PDDocument pdDoc = Loader.loadPDF(pdfContent);`
`170`		`- return pdfStripper.getText(pdDoc);`
	`169`	`+ try (PDDocument pdDoc = Loader.loadPDF(pdfContent)) {`
	`170`	`+ return pdfStripper.getText(pdDoc);`
	`171`	`+ }`
`171`	`172`	`}`
`172`	`173`	`}`