fix: remove lodash functions to decrease bundle size #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmycallin
reviewed
Nov 14, 2022
| decode(data, identityMap = {}) { | ||
| if (data == null) { | ||
| return data; |
There was a problem hiding this comment.
what happened with this initial null check?
There was a problem hiding this comment.
I removed it. The rest of the checks are not picking up null, and the "default" return is also data. That, combined with it being loose equality and thus probably subject to some kind of weird quirks that I didn't feel like googling, made me remove it.
There was a problem hiding this comment.
Loose equality for null can be used for null or undefined:
> "null == null: " true
> "undefined == null: " true
> "0 == null: " false
> "false == null: " false
Since undefined is not valid JSON (which is what is being decoded), this will only be null. null fails the checks, and is returned as passed in as before. All good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In an effort to reduce package size lodash was replaced by native functions. Packages were also updated.
Test
Make sure everything works as before.