feat: Support use blob to createComponent #20
Conversation
There was a problem hiding this comment.
Hi @WaylonFtrack! Would you mind looking into getting the tests for file uploading to work (they are currently skipped), and add an additional test for blobs? Thanks!
jimmycallin
changed the title
|
Is the goal to add support for browsers not supporting the File constructor, or what is the motivation for the change? |
|
I was trying to upload canvas image from HTMLCanvasElement.toBlob. Since file constructor is additional wrapper, and the changes to directly support |
| @@ -825,9 +829,13 @@ export class Session { | |||
| let headers; | |||
|
|
|||
| const updateOnProgressCallback = (oEvent) => { | |||
| let progress = 0; | |||
There was a problem hiding this comment.
jsdom won't set request headers before request, cause onProgress never be called in test enviroment.
There was a problem hiding this comment.
I'm happy with this, but would like @lucaas to approve as well! Good job with the tests as well!
I see. In the review player, we also use |
No description provided.