Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move predicates into predicates package #508

Open
fthomas opened this issue May 15, 2018 · 0 comments
Open

Move predicates into predicates package #508

fthomas opened this issue May 15, 2018 · 0 comments

Comments

@fthomas
Copy link
Owner

fthomas commented May 15, 2018

The predicates in refined are currently organized in objects (like numeric, string, etc.) in the eu.timepit.refined package. With the addition of predefined refined types in eu.timepit.refined.types the predicates became a little bit less important (since now if you want to use NonEmptyString for example, the only thing you need to import is eu.timepit.refined.types.string.NonEmptyString). It is also unfortunate that we have eu.timepit.refined.string and eu.timepit.refined.types.string while it is not obvious from the package name that the former only contains predicates.

So to clean up the package structure, I'd like to move all predicates to eu.timepit.refined.predicates so that predicates are on the same level as refined types. The .refined.predicates package is already there but currently only contains forwarders to the actual predicates in refined and an all object which allows to import all predicates (to support #184).

Care should be taken when doing this to minimize breakage of binary and source compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant