Merge pull request #757 from isidentical/lexists

spec: implement lexists()

Author: martindurant

fsspec/implementations/local.py

@@ -105,6 +105,9 @@ def info(self, path, **kwargs):
                 result["size"] = 0
         return result
 
+    def lexists(self, path, **kwargs):
+        return osp.lexists(path)
+
     def cp_file(self, path1, path2, **kwargs):
         path1 = self._strip_protocol(path1).rstrip("/")
         path2 = self._strip_protocol(path2).rstrip("/")

fsspec/implementations/tests/test_local.py

@@ -527,6 +527,35 @@ def test_linked_files(tmpdir):
         assert f.read() == data
 
 
+def test_linked_files_exists(tmpdir):
+    origin = tmpdir / "original"
+    copy_file = tmpdir / "copy"
+
+    fs = LocalFileSystem()
+    fs.touch(origin)
+
+    try:
+        os.symlink(origin, copy_file)
+    except OSError:
+        if WIN:
+            pytest.xfail("Ran on win without admin permissions")
+        else:
+            raise
+
+    assert fs.exists(copy_file)
+    assert fs.lexists(copy_file)
+
+    os.unlink(origin)
+
+    assert not fs.exists(copy_file)
+    assert fs.lexists(copy_file)
+
+    os.unlink(copy_file)
+
+    assert not fs.exists(copy_file)
+    assert not fs.lexists(copy_file)
+
+
 def test_linked_directories(tmpdir):
     tmpdir = str(tmpdir)
 

fsspec/spec.py

@@ -579,6 +579,11 @@ def exists(self, path, **kwargs):
             # any exception allowed bar FileNotFoundError?
             return False
 
+    def lexists(self, path, **kwargs):
+        """If there is a file at the given path (including
+        broken links)"""
+        return self.exists(path)
+
     def info(self, path, **kwargs):
         """Give details of entry at path