Apply configuration to builder classes

[ppilev]

hello,

is there some way we can directly apply instances of configuration objects to client, producer, consumer builders instead of using applying each config value one by one through builder fluent api?

what would ultimately work for my case for example is making With(ProducerConfiguration newConfig) method public.
is there any reason keeping those methods internal?

thanks,

[Lanayx]

What is the use case that you are trying to solve that can't be solved with existing API? Also, is your suggested approach supported by Java client?

[ppilev]

the use case is when the configuration is stored externally and loaded at startup trough IConfiguration.

I'm not familiar with Java api but I will check it.
thanks,

[Lanayx]

Thank you, if similar functionality is available in Java, I'm ok to make .With methods public

[ppilev]

hello,
I've verified that all builder interfaces in Java have provided this public method:

XxxClientBuilder loadConf(Map<String, Object> config);

however another issue I'm facing with F# version of the configuration types is they cannot be instantiated by configuration binders and cannot be used directly with options pattern in .net which I think is due to the config props don't have setters.

[Lanayx]

For the setters issue, I think [<CLIMutable>] attribute should fix the issue. So it looks we have two options

1. Open ".With" methods and add attribute to all configuration classes
2. Implement LoadConf methods similar to Java.

I'm ok with any of those options, so you can send a PR with the required changes and new test.

[ppilev]

hello,
I added [<CLIMutable>] and made With methods public and now options pattern in .net app works correctly, however I struggle with two things:

1. adding a proper unit test - since this change is mostly about adding support for .net options pattern I'm not quite sure what test exactly to add about it - should I run a test with IConfiguration and IOptions<T> or rather that just verifying there is a default .ctor and the properties have setters?
2. adding examples - the examples project is referencing "Pulsar.Client" Version="3.6.1" />. how can add new examples if Pulsar.Client proj is not referenced directly?

thanks,

[Lanayx]

1. No, there is no need in introducing IConfiguration or IOptions in tests, additional test (probably just copy of "Sent messageId should be equal to received messageId") should just use new .With APIs instead of builder to verify that they are indeed working. The configuration object you can take from another builder either by using Configuration property, or passing updated Default configuration or even deserializing from json string using built-in STJ deserializer.
2. If you wish to add examples, you can do it as a second PR after first one is merged and new library version is published on nuget.