Revisit long members in a type declaration. #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smaug123
approved these changes
Jan 15, 2021
Smaug123
reviewed
Jan 15, 2021
Contributor
Smaug123
left a comment
Smaug123
left a comment
There was a problem hiding this comment.
Actually, could we please have a test case for when the two issues happen together?
type IFoo =
abstract Bar :
i : int
-> a : string
* foo : int
-> stringor whatever happens? (As long as something reasonably sane happens, I don't mind what it is.)
Smaug123
approved these changes
Jan 15, 2021
Contributor
Smaug123
left a comment
Smaug123
left a comment
There was a problem hiding this comment.
Happy with the additional tests, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1362.
@Smaug123 having the arrows at the start or at the end is not really a big deal for Fantomas.