Don't just silently fail if git fails #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prints a message to the sublime text console, passing on any messages from git, if the command returns an error code. Previously this just failed silently, making it look like the plugin just didn't work.
|
Its actually only defined here -> https://git-scm.com/docs/git-show#git-show---minimal I'll merge your PR tomorrow once i get a better look, as right now its a little late for me. |
psykzz
approved these changes
Jun 25, 2017
Thanks! I looked at diff/blame and searched the main man page but obviously missed that one 😃 |
|
Sorry for being slow in merging, i've merged this now, will cut a release in a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought the package didn't work, because nothing happened and there was no messages in the console. But it turns out the machine I was working on didn't have a recent version of git. This patch changes the package to echo out the git error to the sublime text console if this happens.
Incidentally, I can't find any documentation for the
--minimalargument togit blame. Does it change the output significantly?