Skip to content

Commit d567a41

Browse files
committed
Remove unnecessary NotImplementedErrors
1 parent 090398e commit d567a41

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/blame_all.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,7 @@ def close_by_user_request(self):
9494
self.view.run_command("blame_erase_all")
9595

9696
def rerun(self, **kwargs):
97-
# BlameAll rerunning itself doesn't make sense.
98-
raise NotImplementedError()
97+
self.run(None)
9998

10099
# Overrides end --------------------------------------------------------------------
101100

src/blame_inline.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,18 +53,16 @@ def on_post_save_async(self):
5353
# Overrides (BaseBlame) ------------------------------------------------------------
5454

5555
def extra_cli_args(self, line_num):
56-
args = ["-L", "{0},{0}".format(line_num), "--date=relative"]
57-
return args
56+
return ["-L", "{0},{0}".format(line_num), "--date=relative"]
5857

5958
def _view(self):
6059
return self.view
6160

6261
def close_by_user_request(self):
63-
# Inline Blame phantoms doesn't have a user-accessible close UI.
64-
raise NotImplementedError()
62+
self.view.erase_phantoms(INLINE_BLAME_PHANTOM_SET_KEY)
6563

6664
def rerun(self, **kwargs):
67-
self.view.erase_phantoms(INLINE_BLAME_PHANTOM_SET_KEY)
65+
self.close_by_user_request()
6866
if self.timer:
6967
self.timer.cancel()
7068
self.timer = threading.Timer(self.delay_seconds, self.show_inline_blame)

0 commit comments

Comments
 (0)