WIP fix issues identified by mypy

Author: frou

src/base.py

@@ -3,7 +3,7 @@
 import subprocess
 import sys
 from abc import ABCMeta, abstractmethod
-from urllib.parse import parse_qs, quote_plus, urlparse
+from urllib.parse import parse_qs, urlparse
 
 import sublime
 
@@ -96,12 +96,12 @@ def handle_phantom_button(self, href):
         elif url.path == "show":
             sha = querystring["sha"][0]
             try:
-                desc = self.get_commit_text(sha, self.view.file_name())
+                desc = self.get_commit_text(sha, self._view().file_name())
             except Exception as e:
                 self.communicate_error(e)
                 return
 
-            buf = self.view.window().new_file()
+            buf = self._view().window().new_file()
             buf.run_command(
                 "blame_insert_commit_description",
                 {"desc": desc, "scratch_view_name": "commit " + sha},

src/blame_all.py

@@ -27,7 +27,7 @@ def run(self, edit):
             return
 
         self.view.erase_phantoms(PHANTOM_KEY_ALL)
-        phantoms = []  # type: list[sublime.Phantom]
+        phantoms = []  # type: list[sublime.Phantom] # type: ignore[misc]
 
         # If they are currently shown, toggle them off and return.
         if self.view.settings().get(VIEW_SETTING_PHANTOM_ALL_DISPLAYED, False):

src/blame_inline.py

@@ -1,21 +1,23 @@
 import threading
+
 import sublime
 import sublime_plugin
 
 from .base import BaseBlame
-from .templates import blame_inline_phantom_css, blame_inline_phantom_html_template
 from .settings import (
-    pkg_settings,
-    PKG_SETTINGS_KEY_INLINE_BLAME_ENABLED,
     PKG_SETTINGS_KEY_INLINE_BLAME_DELAY,
+    PKG_SETTINGS_KEY_INLINE_BLAME_ENABLED,
+    pkg_settings,
 )
+from .templates import blame_inline_phantom_css, blame_inline_phantom_html_template
 
 INLINE_BLAME_PHANTOM_SET_KEY = "git-blame-inline"
 
 
 class BlameInlineListener(BaseBlame, sublime_plugin.ViewEventListener):
     @classmethod
     def is_applicable(cls, settings):
+        # @todo Fix inline blame (sometimes?) remaining enabled when the user setting for it is edited from true -> false
         return pkg_settings().get(PKG_SETTINGS_KEY_INLINE_BLAME_ENABLED)
 
     def __init__(self, view):