fix: Still process if translation fails

Author: philipbrembeck

OpenAPI.yaml

@@ -79,14 +79,11 @@ paths:
             type: string
       responses:
         '200':
-          description: Request returned a positive result.
+          description: >-
+            Request returned a positive result. If translation fails, results
+            will be based on untranslated ingredients.
         '500':
           description: Internal Server Error.
-        '503':
-          description: >-
-            Service Unavailable. Translation service is unavailable. Try again
-            with disabled translation (Results might vary). Add flag
-            ?translate=false to the request.
       tags:
         - IngredientsV1
         - Ingredients

src/ingredients/tests/ingredientsv1.controller.spec.ts

@@ -185,20 +185,26 @@ describe("IngredientsV1Controller", () => {
       });
     });
 
-    it("should handle translation service unavailable", async () => {
+    it("should process untranslated ingredients when translation fails", async () => {
       const res = mockResponse();
       translationService.translateText.mockRejectedValueOnce(
         new Error("Translate timed out")
       );
 
-      await controller.getIngredients("ingredient", res, true);
+      await controller.getIngredients("tofu,milk,sugar", res, true);
 
-      expect(res.status).toHaveBeenCalledWith(HttpStatus.SERVICE_UNAVAILABLE);
+      expect(res.status).toHaveBeenCalledWith(HttpStatus.OK);
       expect(res.send).toHaveBeenCalledWith({
-        code: "Service Unavailable",
-        status: "503",
-        message:
-          "Translation service is unavailable. Try again with disabled translation (Results might vary). Add flag ?translate=false to the request.",
+        code: "OK",
+        status: "200",
+        message: "Success",
+        data: {
+          vegan: false,
+          surely_vegan: ["tofu"],
+          not_vegan: ["milk"],
+          maybe_not_vegan: ["sugar"],
+          unknown: [],
+        },
       });
     });
 

src/ingredients/v1/ingredients.controller.ts

@@ -77,17 +77,13 @@ export class IngredientsV1Controller implements OnModuleInit {
   @ApiTags("Ingredients")
   @ApiResponse({
     status: 200,
-    description: "Request returned a positive result.",
+    description:
+      "Request returned a positive result. If translation fails, results will be based on untranslated ingredients.",
   })
   @ApiResponse({
     status: 500,
     description: "Internal Server Error.",
   })
-  @ApiResponse({
-    status: 503,
-    description:
-      "Service Unavailable. Translation service is unavailable. Try again with disabled translation (Results might vary). Add flag ?translate=false to the request.",
-  })
   async getIngredients(
     @Param("ingredients") ingredientsParam: string,
     @Res() res: Response,
@@ -128,34 +124,11 @@ export class IngredientsV1Controller implements OnModuleInit {
 
           response = this.parseIngredients(translated);
         } catch (error) {
-          if (error instanceof Error) {
-            if (error.message === "Translate timed out") {
-              this.logger.error(`Translation service is unavailable: ${error}`);
-              res.status(HttpStatus.SERVICE_UNAVAILABLE).send({
-                code: "Service Unavailable",
-                status: "503",
-                message:
-                  "Translation service is unavailable. Try again with disabled translation (Results might vary). Add flag ?translate=false to the request.",
-              });
-              return;
-            } else {
-              this.logger.error(`Error during translation: ${error}`);
-              res.status(HttpStatus.INTERNAL_SERVER_ERROR).send({
-                code: "Internal Server Error",
-                status: "500",
-                message: "An error occurred during the translation process",
-              });
-              return;
-            }
-          } else {
-            this.logger.error(`Unknown error: ${error}`);
-            res.status(HttpStatus.INTERNAL_SERVER_ERROR).send({
-              code: "Internal Server Error",
-              status: "500",
-              message: "An unknown error occurred while processing the request",
-            });
-            return;
-          }
+          this.logger.warn(
+            `Translation failed, proceeding with untranslated ingredients: ${error}`
+          );
+          response = ingredients;
+          targetLanguage = "EN";
         }
       } else {
         response = ingredients;
@@ -220,13 +193,16 @@ export class IngredientsV1Controller implements OnModuleInit {
             translatedUnknown
           );
         } catch (error) {
-          this.logger.error(`Error during back translation: ${error}`);
-          res.status(HttpStatus.INTERNAL_SERVER_ERROR).send({
-            code: "Internal Server Error",
-            status: "500",
-            message: "An error occurred during the back translation process",
-          });
-          return;
+          this.logger.warn(
+            `Back translation failed, using untranslated results: ${error}`
+          );
+          this.sendResponse(
+            res,
+            notVeganResult,
+            maybeNotVeganResult,
+            veganResult,
+            unknownResult
+          );
         }
       } else {
         this.sendResponse(