Search does not handle collapse

[ekvalheim]

When you collapse the parent of a hit from the search (marked with red border), the marked hit of the search is moved to another node which does not match the search.

Example:

1. Open the Demo https://fritz-c.github.io/react-sortable-tree/
2. Expand All
3. Search for the text: "Nested", and you get a hit on second child of "title"
4. Collapse the first node "title" and the hit is moved to "Chicken"

[fritz-c]

Indeed it does. Thank you for pointing this out, and I'll be working on it when I have some free time.

[fritz-c]

I looked into this this morning, and recalled a compromise I made that I should note here so I don't forget it again.

After searching, the matches array will provide paths and treeIndexes for each match.

Using the treeIndex to highlight matches:
In mid-drag, search is not performed on each update for (assumed) performance reasons. The result is that outlines "linger" on their old positions until the drop is performed.
Hidden nodes (such as the one in your report) have a null treeIndex, and are not highlighted.

Using the last key in the path to highlight matches (the existing method):
The outlines follow around the nodes in mid-drag (assuming you use some unique key other than treeIndex in getNodeKey)
When using the treeIndex in getNodeKey, hidden matches will result in broken highlighting.

[cristianocca]

Even without using drag and drop at all, just collapsing the parent node of a search match will cause the bug, another unrelated node being highlighted.