First commit #2
Open
First commit #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zing and border treatment.
… carousel card CSS treatment.
… height and object-fit on large prop image.
…ates to .json data files.
…pertyCard CSS (flexbox).
…ties and locations.
…ed properties data file with new images.
…s and Maps components. Added PropType checking.
added 6 commits
May 13, 2022 13:32
…offline with animated dots.
…ents. Addition of PropType checking.
bhague1281
reviewed
May 27, 2022
| lat: lat, | ||
| lng: lng, | ||
| }; | ||
| }, [lat, lng]); |
There was a problem hiding this comment.
This works fine. It'll also work if you pass {lat, lng} directly where you're passing center, but that's a bit repetitive. Otherwise, useCallback will throw a lint error wanting you to use useMemo for center.
| }) { | ||
| useEffect(() => { | ||
| window.scrollTo(0, 0); | ||
| }, []); |
There was a problem hiding this comment.
I feel like this should be a reusable hook, considering how often it needs to be used with react-router 😅
| import locationData from "./_data/locations.json"; | ||
|
|
||
| export default function App() { | ||
| let [cartItems, setCartItems] = useState([]); |
There was a problem hiding this comment.
Great job! And yes, this would be a good case to use the Context API + useContext. Try it out if you have some time!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Week 3 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.
Comments
A great project with loads of opportunities for trying and learning new things.
Questions
I used
useMemo()in my Map component to prevent the map from rendering on clicks. Can you weigh in on my approach? I'm pretty sureuseMemo()could also have been used around the actual map return, but I figured if the map depends on the center point, memoizing the center point should do the job.I considered digging into
useContextas I'm passing thecartItemsto all my children components. In the end, I didn't get to that, but am still curious whether that would be a good use for the context API?