Feat add import rules for eslint #37
Conversation
There was a problem hiding this comment.
Setting up the ESLint rules is a good idea.
But please note these:
- The code formatter (Prettier) & Linter (ESLint) should work integrated. It means the code formatter should fix the linter issues & the linter should accept the formatted code.
In This case, Sorting rules are added to the linter, But the code formatter does not sort the lines! - I think the new-line between each import is not a good idea. We can remove this rule.
There was a problem hiding this comment.
The commit message type can be refactor instead of fix.
It's not a bug-fix issue, it's refactoring the code.
There was a problem hiding this comment.
I' fix the eslint to fix lint issue on save.I think you got it wrong.import files are seperated base on their group not on every import line and also I think if our import files in some files are too much,that way,new-line between imports will be a good idea.
There was a problem hiding this comment.
Okay. Now I can say it's a good idea and we can apply this rule.
However, according to the current situation of the repository with multiple pull-request pending for merge, I think it's better to hold this PR for the future to prevent these rule's side effects on other PRs.
We can come back and apply these rules when we are good in the timing plan.
No description provided.