avformat/matroskaenc: Fix leak when writing attachment without filename

mkver · mkver · commit 450f5ae49d87 · 2021-04-10T05:17:21.000+02:00
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> (cherry picked from commit 08c805f)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
@@ -1768,6 +1768,7 @@ static int mkv_write_attachments(AVFormatContext *s)
             put_ebml_string(dyn_cp, MATROSKA_ID_FILEDESC, t->value);
         if (!(t = av_dict_get(st->metadata, "filename", NULL, 0))) {
             av_log(s, AV_LOG_ERROR, "Attachment stream %d has no filename tag.\n", i);
+            ffio_free_dyn_buf(&dyn_cp);
             return AVERROR(EINVAL);
         }
         put_ebml_string(dyn_cp, MATROSKA_ID_FILENAME, t->value);

Original file line number	Diff line number	Diff line change
`@@ -1768,6 +1768,7 @@ static int mkv_write_attachments(AVFormatContext *s)`
`1768`	`1768`	`put_ebml_string(dyn_cp, MATROSKA_ID_FILEDESC, t->value);`
`1769`	`1769`	`if (!(t = av_dict_get(st->metadata, "filename", NULL, 0))) {`
`1770`	`1770`	`av_log(s, AV_LOG_ERROR, "Attachment stream %d has no filename tag.\n", i);`
	`1771`	`+ ffio_free_dyn_buf(&dyn_cp);`
`1771`	`1772`	`return AVERROR(EINVAL);`
`1772`	`1773`	`}`
`1773`	`1774`	`put_ebml_string(dyn_cp, MATROSKA_ID_FILENAME, t->value);`