Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onModelChange callback not working when using FroalaEditorComponent inside react web component with shadow root #388

Open
ghost opened this issue Dec 9, 2023 · 8 comments

Comments

@ghost
Copy link

ghost commented Dec 9, 2023

I have a react web component with shadow root, when I open the froala editor inside it by initializing editor FroalaEditorComponent everything works except for onModelChange function , this function does not return in model. it is always undefined.

@os-lmo
Copy link

os-lmo commented Dec 11, 2023

I am also facing the same issue.
I know that, using the fullPage prop, we can overcome this issue. But, in that case, some other features will not work properly like popover position

@Amit-Milli
Copy link

Any update on this? this is very crucial for us!! When I use fullPage boolean prop as true all the css that we have written already gets affected. how can we make froala editor work seamlessly inside a shadowDOM?

@ghost
Copy link
Author

ghost commented Mar 14, 2024

Any update on this? This is hurting us real bad.

@ghost
Copy link
Author

ghost commented Mar 14, 2024

I am also facing the same issue. I know that, using the fullPage prop, we can overcome this issue. But, in that case, some other features will not work properly like popover position

Were you able to find a solution for this?

@loganvolkers
Copy link

loganvolkers commented Apr 30, 2024

It looks like Froala may not support being rendered in a Shadow Root. Here's a small self-contained minimal example that shows it not working as expected: https://jsfiddle.net/m2z4ys8a/1/

This shows that this exists in the core library, and isn't limited to the React wrapper.

@ilyaskarim
Copy link

Support for Shadow DOM in the WYSIWYG editors is limited, and it may lead to unexpected behavior and styling issues, as you have experienced. While loading the required styles in your app is a step in the right direction, there are certain limitations when it comes to the proper functioning of the editor within the Shadow DOM environment.
For that reason, Froala strongly recommend enabling the iframe/fullPage option to avoid unwanted conflicts in the editor functionality when working inside a shadow DOM element.
Froala users are welcome to submit requests regarding their issues with iframe/fullPage, and we will provide solutions for them: https://froala.com/wysiwyg-editor/contact/

@emilianionascu
Copy link

Same issue here as well. What is it that prevents Froala from working properly in a Shadow DOM?

@hectordvv
Copy link

Enabling full page on editor worked for me.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants