Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what is the expected directory structure under svg? #256

Closed
mMerlin opened this issue Jul 27, 2020 · 1 comment
Closed

what is the expected directory structure under svg? #256

mMerlin opened this issue Jul 27, 2020 · 1 comment

Comments

@mMerlin
Copy link
Contributor

mMerlin commented Jul 27, 2020

I just noticed something unexpected based on the pattern I see for the reset of the folders. There is a "user" folder, inside of svg/core. I was only expected to see that as svg/user. It looks like the user folder got duplicated sometime. A long time ago.

git log --diff-filter=A -- svg/core/user/breadboard/placeholder.txt
git log --diff-filter=A -- svg/user/breadboard/placeholder.txt 

shows that those were both created some time before the parts history was reset in 2016.

A full list of the user related files and folders is:

% find . -name "*" -print | grep "user"
./user
./user/placeholder.txt
./user/74xx08.fzp
./svg/core/user
./svg/core/user/breadboard
./svg/core/user/breadboard/placeholder.txt
./svg/core/user/schematic
./svg/core/user/schematic/placeholder.txt
./svg/core/user/icon
./svg/core/user/icon/placeholder.txt
./svg/core/user/pcb
./svg/core/user/pcb/placeholder.txt
./svg/user
./svg/user/breadboard
./svg/user/breadboard/placeholder.txt
./svg/user/breadboard/74xx08_breadboard.svg
./svg/user/schematic
./svg/user/schematic/placeholder.txt
./svg/user/schematic/74xx08_schematic.svg
./svg/user/icon
./svg/user/icon/placeholder.txt
./svg/user/icon/74xx08_icon.svg
./svg/user/pcb
./svg/user/pcb/placeholder.txt
./svg/user/pcb/74xx08_pcb.svg

What is that 74xx08 part doing in the user folder of the core parts library? That was added 2016/09/29.

I can do a PR to get rid of that, but need to know that it is actually an error (or 2 errors)

@KjellMorgenstern
Copy link
Member

KjellMorgenstern commented Oct 27, 2020

This was already removed once, see 0a2b976
Probably it was reintroduced during a merge conflict or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants