Fix Qt6 build failure on QDomDocument::ParseResult conversion error #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/model/modelbase.cpp: In member function ‘ModelPart* ModelBase::createOldSchematicPartAux(ModelPart*, const QString&, const QString&, const QString&)’:
src/model/modelbase.cpp:847:36: error: cannot convert ‘QDomDocument::ParseResult’ to ‘bool’ in initialization
847 | bool ok = oldDoc.setContent(&newFzp);
| ~~~~~~~~~~~~~~~~~^~~~~~~~~
| |
| QDomDocument::ParseResult
Ensure Qt6 uses the deprecated:
bool QDomDocument::setContent(const QByteArray &buffer, QString
*errorMsg, int *errorLine = nullptr, int *errorColumn = nullptr)
which in Qt5 is:
bool QDomDocument::setContent(const QByteArray &buffer, QString
*errorMsg = nullptr, int *errorLine = nullptr, int *errorColumn = nullptr)
|
I just did a succesful build with Qt6.6.1. A ton of deprecation warnings but no build failure. |
|
Yes, the code was updated: bd010ce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure Qt6 uses the deprecated:
bool QDomDocument::setContent(const QByteArray &buffer, QString *errorMsg, int *errorLine = nullptr, int *errorColumn = nullptr)
which in Qt5 is:
bool QDomDocument::setContent(const QByteArray &buffer, QString *errorMsg = nullptr, int *errorLine = nullptr, int *errorColumn = nullptr)