Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parts should have a selectionShape #52

Open
davidperrenoud opened this issue Aug 25, 2014 · 9 comments
Open

Parts should have a selectionShape #52

davidperrenoud opened this issue Aug 25, 2014 · 9 comments

Comments

@davidperrenoud
Copy link
Contributor

From dirk.van...@gmail.com on December 06, 2007 07:23:41

Parts should have an outer shape.
This outer border shape should not necessarily be the same as the bounding box.

This outer shape will be used when drawing a selection ring around a part
or when drawing the dragged ghost image indicating where the dropped part
will be placed.

Also this outer shape does not necessarily have to contain all the inner
elements of a part. E.g. a part could have strange long wires or hairs
coming out of it; then the outer shape doesn't have to encompass all of
these hairs.

Original issue: http://code.google.com/p/fritzing/issues/detail?id=52

@davidperrenoud
Copy link
Contributor Author

From dirk.van...@gmail.com on December 24, 2007 02:32:08

There are two shapes:

  1. the selectionShape (a polygon shape drawn as a shadow to indicate the drop
    destination of the part)
  2. a boundingBox (a rectangle for the drawing mechanism to know which area of the
    screen to redraw in case of an update)

Status: Accepted

@davidperrenoud
Copy link
Contributor Author

From dirk.van...@gmail.com on December 24, 2007 02:32:40

Summary: Parts should have a selectionShape

@davidperrenoud
Copy link
Contributor Author

From dirk.van...@gmail.com on January 18, 2008 01:44:43

Owner: co...@irascible.com
Cc: -co...@irascible.com dirk.van.oosterbosch

@davidperrenoud
Copy link
Contributor Author

From irasc...@gmail.com on June 07, 2013 23:25:15

comments 4 and up are actually a separate issue #2611

@davidperrenoud
Copy link
Contributor Author

From irasc...@gmail.com on June 07, 2013 23:27:10

Labels: -Priority-Medium Priority-Low

@failiz
Copy link
Contributor

failiz commented Mar 21, 2021

remove imported label

@KjellMorgenstern
Copy link
Member

#2609 uses the parts shape, not the bounding box. Isn't this a duplicate?

@failiz
Copy link
Contributor

failiz commented Mar 21, 2021

It looks like a duplicate, but I cannot observe this behavior implemented. All the parts that I tried use the bounding box for selection. This is obvious in non rectangular shapes, for example holes, linear potentiometer, coils, etc.

@KjellMorgenstern
Copy link
Member

Indeed although #2609 was closed, it is not implemented, or at least not used. And it might make it easier to select parts in many cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants