Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Fritzing part editor for through-hole drilling (THT components) #3704

Open
greenhilldev opened this issue Aug 15, 2020 · 0 comments
Open
Labels

Comments

@greenhilldev
Copy link

greenhilldev commented Aug 15, 2020

Problem

The following description reflects fritzing's part editor, mainly the PCB view:
Upon SVG import, the part editor checks the SVG file for proper named layers, but it does not check the given xml element names inside the SVG.
When importing a SVG file for PCB view, the xml element name for the part's holes (drills) can be named as "ellipse" and then set to THT inside the part editor. Fritzing is showing the part correctly!
This will run into an error later when it comes to production, because (some) gerber viewers do not perform drills for holes which are described as "ellipse" inside the svg. They insist on a proper identification as "circle" , which seems fully logical.
Fritzing: 0.9.4. on macOS Catalina

inkscape_part_creation_IMPORTANT

Side Note

When exporting a PCB view out of Inkscape as an SVG (Inkscape is referenced in most tutorials about fritzing part creation) all drawn circles might not be defined as "circle", most likely they are defined as "ellipse" with rx and ry having nearly the same value.

Proposed Solution

The fritzing part editor could throw a warning when the imported SVG file contains xml elements which are named "ellipse" and the user tries to set them to THT.

@KjellMorgenstern KjellMorgenstern added this to the 0.9.6 milestone Aug 31, 2020
@KjellMorgenstern KjellMorgenstern modified the milestones: 0.9.7, 0.9.8 Jul 6, 2021
@KjellMorgenstern KjellMorgenstern removed this from the 0.9.9 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants