feat(run): Add tty option

Author: relekang

docker/manager.py

@@ -60,7 +60,7 @@ def __exit__(self, exc_type, exc_value, exc_traceback):
         if exc_value:
             raise exc_value
 
-    def run(self, command, working_directory='', stdin='', login=True):
+    def run(self, command, working_directory='', stdin='', login=True, tty=True):
         """
         Runs the command with docker exec in the given working directory.
 
@@ -74,6 +74,8 @@ def run(self, command, working_directory='', stdin='', login=True):
         :type stdin: str
         :param login: Will add --login on the bash call.
         :type login: boolean
+        :param tty: Will add -t on the bash call.
+        :type tty: boolean
         :return: A ProcessResult object containing information on the result of the command.
         :rtype: ProcessResult
         """
@@ -89,10 +91,11 @@ def run(self, command, working_directory='', stdin='', login=True):
         ])
 
         result = execute(
-            'docker exec -i {container} bash {login} -c \'{command}\''.format(
+            'docker exec -i{tty} {container} bash{login} -c \'{command}\''.format(
                 envs=env_string,
                 container=self.container_name,
-                login='--login' if login else '',
+                login=' --login' if login else '',
+                tty=' -t' if tty else '',
                 command=command_string.format(
                     working_directory=working_directory,
                     command=command,

tests/test_manager.py

@@ -70,7 +70,7 @@ def test_quotation_mark_handling(self, mock_run):
         docker.run('echo "hi there"')
         docker.run("echo 'hi there'")
         expected = (
-            'docker exec -i {} bash --login -c \'cd ~/ &&  echo "hi there"\''.format(
+            'docker exec -i -t {} bash --login -c \'cd ~/ &&  echo "hi there"\''.format(
                 docker.container_name
             ),
             ''
@@ -84,7 +84,7 @@ def test_env_variables(self, mock_run):
         docker = Docker(env_variables={'CI': 1, 'FRIGG': 1})
         docker.run('ls')
         mock_run.assert_called_once_with(
-            'docker exec -i {} bash --login -c \'cd ~/ && CI=1 FRIGG=1 ls\''.format(
+            'docker exec -i -t {} bash --login -c \'cd ~/ && CI=1 FRIGG=1 ls\''.format(
                 docker.container_name
             ),
             ''
@@ -96,7 +96,7 @@ def test_no_login(self, mock_run):
         docker = Docker()
         docker.run('ls', login=False)
         mock_run.assert_called_once_with(
-            'docker exec -i {} bash  -c \'cd ~/ &&  ls\''.format(docker.container_name),
+            'docker exec -i -t {} bash -c \'cd ~/ &&  ls\''.format(docker.container_name),
             ''
         )