fix(run): Set login and tty options to false as default

Author: relekang

docker/manager.py

@@ -60,7 +60,7 @@ def __exit__(self, exc_type, exc_value, exc_traceback):
         if exc_value:
             raise exc_value
 
-    def run(self, command, working_directory='', stdin='', login=True, tty=True):
+    def run(self, command, working_directory='', stdin='', login=False, tty=False):
         """
         Runs the command with docker exec in the given working directory.
 

tests/test_manager.py

@@ -67,8 +67,8 @@ def test_with_statement_exception(self, mock_start, mock_stop):
     @mock.patch('re.search', lambda *x: None)
     def test_quotation_mark_handling(self, mock_run):
         docker = Docker()
-        docker.run('echo "hi there"')
-        docker.run("echo 'hi there'")
+        docker.run('echo "hi there"', login=True, tty=True)
+        docker.run("echo 'hi there'", login=True, tty=True)
         expected = (
             'docker exec -i -t {} bash --login -c \'cd ~/ &&  echo "hi there"\''.format(
                 docker.container_name
@@ -96,7 +96,7 @@ def test_no_login(self, mock_run):
         docker = Docker()
         docker.run('ls', login=False)
         mock_run.assert_called_once_with(
-            'docker exec -i -t {} bash -c \'cd ~/ &&  ls\''.format(docker.container_name),
+            'docker exec -i {} bash -c \'cd ~/ &&  ls\''.format(docker.container_name),
             ''
         )