[Dash effect] New parameters added#505
Open
pgilfernandez wants to merge 2 commits intofriction2d:mainfrom
Open
[Dash effect] New parameters added#505pgilfernandez wants to merge 2 commits intofriction2d:mainfrom
pgilfernandez wants to merge 2 commits intofriction2d:mainfrom
Conversation
Author
|
@rodlie I've seen the dash export to SVG is kind of hard-coded and not applied to all objects (only paths as far as I have seen). Any idea? |
Member
|
I'm not familiar with the dash svg code, so I will have to take a look. This feature require changes to the project format, so it will have to wait until v1.1. Issues like this will be resolved when we move to the new project format. |
Author
|
Sure! I commented that this was not going to happen for v1.0 so no rush |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #503 I have added some new parameters to control a
outline basedash effect:sizechanges toscalelengthspacingoffsetI did not implemented
number of elementsas, even if I did some tests it did not work properly as it is difficult to control them because it depends on the path length and size in the canvas. Anyway, it could be controlled with thesup-patheffect and animate thecompleteparameter