Turn on some warnings and fix the results

Author: ndmitchell

ghci.bat

@@ -1 +1 @@
-ghci.exe -isrc -i. src\Main.hs -fno-warn-overlapping-patterns -package haskell-src-exts-1.0.0
+ghci.exe -isrc -i. src\Main.hs -fno-warn-overlapping-patterns -w -fwarn-unused-binds -fwarn-unused-imports -package haskell-src-exts-1.0.0

src/CmdLine.hs

@@ -9,7 +9,6 @@ import System.Directory
 import System.Environment
 import System.Exit
 import System.FilePath
-import HSE.All
 
 import Util
 import Paths_hlint

src/HSE/All.hs

@@ -5,10 +5,10 @@ module HSE.All(
     module HSE.Bracket, module HSE.Match,
     module HSE.Generics,
     module HSE.NameMatch,
-    parseFile, parseString
+    parseFile, parseString, fromParseResult
     ) where
 
-import Language.Haskell.Exts hiding (parse, parseFile, paren)
+import Language.Haskell.Exts hiding (parse, parseFile, paren, fromParseResult)
 import qualified Language.Haskell.Exts as HSE
 
 import HSE.Util

src/HSE/Bracket.hs

@@ -3,9 +3,7 @@
 module HSE.Bracket where
 
 import Control.Monad.State
-import Data.Generics
 import Data.Generics.PlateData
-import Data.List
 import Data.Maybe
 import Language.Haskell.Exts
 import HSE.Util

src/HSE/Match.hs

@@ -2,12 +2,9 @@
 
 module HSE.Match where
 
-import HSE.Generics
 import Data.Char
 import Data.List
-import Data.Maybe
 import Language.Haskell.Exts
-import HSE.Bracket
 import HSE.Util
 
 

src/Hint/All.hs

@@ -1,8 +1,6 @@
 
 module Hint.All where
 
-import Control.Monad
-import HSE.All
 import Type
 
 import Hint.Match

src/Hint/Bracket.hs

@@ -22,7 +22,6 @@ yes = (b $ c d) ++ e where res = b (c d) ++ e
 module Hint.Bracket where
 
 import Control.Arrow
-import Data.Maybe
 import Type
 import HSE.All
 

src/Hint/Match.hs

@@ -10,7 +10,6 @@ _noParen_ - don't bracket this particular item
 module Hint.Match(readMatch) where
 
 import Data.Char
-import Data.Generics.PlateData
 import Data.List
 import Data.Maybe
 import Type

src/Hint/Naming.hs

@@ -60,7 +60,6 @@ getNames x = case x of
     _ -> []
     where
         name = [fromNamed x]
-        names = map fromNamed (universeBi x :: [Name])
 
         f (ConDecl x _) = [x]
         f (InfixConDecl _ x _) = [x]

src/Hint/Structure.hs

@@ -17,7 +17,6 @@ module Hint.Structure where
 import HSE.All
 import Type
 import Data.List
-import Data.Char
 import Data.Maybe
 
 

src/Main.hs

@@ -6,9 +6,7 @@ import Control.Arrow
 import Control.Monad
 import Data.List
 import Data.Maybe
-import System.Directory
 import System.Exit
-import Data.Generics.PlateData
 
 import CmdLine
 import Settings
@@ -17,9 +15,7 @@ import Type
 import Test
 import Util
 import Parallel
-import HSE.All
 import Hint.All
-import Paths_hlint
 
 
 main = do

src/Parallel.hs

@@ -5,7 +5,6 @@ import System.IO.Unsafe(unsafeInterleaveIO)
 import GHC.Conc(numCapabilities)
 import Control.Concurrent
 import Control.Monad
-import Control.Parallel
 
 
 parallel :: [IO a] -> IO [a]

src/Report.hs

@@ -4,7 +4,6 @@ module Report(writeReport) where
 
 import Type
 import Control.Arrow
-import Language.Haskell.Exts
 import Data.List
 import Data.Maybe
 import Data.Version

src/Settings.hs

@@ -7,7 +7,6 @@ import Paths_hlint
 import Type
 import Data.Char
 import Data.List
-import System.Directory
 import System.FilePath
 import Util
 import Data.Generics.PlateData

src/Test.hs

@@ -10,11 +10,8 @@ import Data.Maybe
 import Data.Either
 import System.Directory
 import System.FilePath
-import Data.Generics.PlateData
 
-import CmdLine
 import Settings
-import Report
 import Type
 import Util
 import HSE.All