[Provider Context] Update provider creation to intake new payload + changes around it #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraswatpuneet
changed the title
github-actions
bot
added
metadata-changed
github-actions
bot
removed
the
metadata-changed
saraswatpuneet
changed the base branch from
feat/provider-context
to
feat/provider-context-development
github-actions
bot
added
the
metadata-changed
JoeCap08055
reviewed
Aug 11, 2025
JoeCap08055
reviewed
Aug 11, 2025
| /// - [`Error::ExceedsMaxProviderNameSize`] - Too long of a provider name | ||
| #[pallet::call_index(11)] | ||
| #[pallet::weight(T::WeightInfo::propose_to_be_provider())] | ||
| #[pallet::weight(T::WeightInfo::propose_to_be_provider_v2())] |
Collaborator
There was a problem hiding this comment.
Suggested change
| #[pallet::weight(T::WeightInfo::propose_to_be_provider_v2())] | |
| #[pallet::weight(T::WeightInfo::propose_to_be_provider())] |
I think this is the original, not the v2, correct?
Collaborator
There was a problem hiding this comment.
Or are we just using the same weights for both?
Collaborator
Author
There was a problem hiding this comment.
I assume we can since its calling underlying extrinsic (re-routing after size check), you suggest we have separate benchmarks for both?
JoeCap08055
reviewed
Aug 11, 2025
| /// * [`Error::DuplicateProviderRegistryEntry`] - a ProviderRegistryEntry associated with the given MSA id already exists. | ||
| #[pallet::call_index(12)] | ||
| #[pallet::weight(T::WeightInfo::create_provider_via_governance())] | ||
| #[pallet::weight(T::WeightInfo::create_provider_via_governance_v2())] |
Collaborator
There was a problem hiding this comment.
same question as above
Collaborator
Author
There was a problem hiding this comment.
Same thoughts, we have bench marked v2 in this case and v1 extrinsic just re-route call to v2 with default payload, not sure if we should benchmark both
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
JoeCap08055
approved these changes
Aug 12, 2025
Collaborator
JoeCap08055
left a comment
JoeCap08055
left a comment
There was a problem hiding this comment.
some nits leftover, but nothing blocking
nice work!
github-actions
bot
added
metadata-changed
saraswatpuneet
merged commit f673341
into
feat/provider-context-development
31 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR introduces changes required to support the new Provider Context model as outlined in the Provider Contexts Design Doc. It updates the structure and handling of providers to allow them to represent a company with one or more applications, supporting internationalized metadata and trusted branding via content-addressed hashes.
Closes #2523
Summary of Changes
Registry and Extrinsics
Updated ProviderRegistryEntry:
Replaces the old struct name with a new struct supporting:
default_name: BoundedString
default_logo: Option
localized_name: BoundedBTreeMap<LanguageCode, BoundedString>
localized_logo: BoundedBTreeMap<LanguageCode, Cid>
Updated propose_to_be_provider extrinsic:
Updated create_provider_by_governance extrinsic
Updated create_provider extrinsic
Updated Benchmarks
Updated Unit tests/e2e tests
Added e2e tests
Added unit tests
Added
ProviderToRegistryEntryto migration to storage version2Tested try-runtime migration with
PaseoandMainnetand it worksIn progress
Checklist
Snaps
on_runtime_upgradevia try-runtime cli on paseo