Remove support for user_agent, removing unneeded i/o (#1093)

Author: frenck

src/adguardhome/adguardhome.py

@@ -5,7 +5,6 @@
 import asyncio
 import json
 import socket
-from importlib import metadata
 from typing import Any, Mapping, Self
 
 import aiohttp
@@ -35,7 +34,6 @@ def __init__(  # noqa: PLR0913
         request_timeout: int = 10,
         session: aiohttp.client.ClientSession | None = None,
         tls: bool = False,
-        user_agent: str | None = None,
         username: str | None = None,
         verify_ssl: bool = True,
     ) -> None:
@@ -53,7 +51,6 @@ def __init__(  # noqa: PLR0913
             request_timeout: Max timeout to wait for a response from the API.
             session: Optional, shared, aiohttp client session.
             tls: True, when TLS/SSL should be used.
-            user_agent: Defaults to PythonAdGuardHome/<version>.
             username: Username for HTTP auth, if enabled.
             verify_ssl: Can be set to false, when TLS with self-signed cert is used.
 
@@ -69,11 +66,6 @@ def __init__(  # noqa: PLR0913
         self.tls = tls
         self.username = username
         self.verify_ssl = verify_ssl
-        self.user_agent = user_agent
-
-        if user_agent is None:
-            version = metadata.version(__package__)
-            self.user_agent = f"PythonAdGuardHome/{version}"
 
         if self.base_path[-1] != "/":
             self.base_path += "/"
@@ -130,7 +122,6 @@ async def request(  # noqa: PLR0913
             auth = aiohttp.BasicAuth(self.username, self.password)
 
         headers = {
-            "User-Agent": self.user_agent,
             "Accept": "application/json, text/plain, */*",
         }
 

tests/test_adguardhome.py

@@ -122,43 +122,6 @@ async def test_request_base_path(aresponses: ResponsesMockServer) -> None:
         assert response == {"message": "OMG PUPPIES!"}
 
 
-async def test_request_user_agent(aresponses: ResponsesMockServer) -> None:
-    """Test AdGuard Home client sending correct user agent headers."""
-
-    # Handle to run asserts on request in
-    async def response_handler(request: aiohttp.ClientResponse) -> Response:
-        """Response handler for this test."""
-        assert request.headers["User-Agent"] == "PythonAdGuardHome/0.0.0"
-        return aresponses.Response(text="TEDDYBEAR", status=200)
-
-    aresponses.add("example.com:3000", "/", "GET", response_handler)
-
-    async with aiohttp.ClientSession() as session:
-        adguard = AdGuardHome("example.com", base_path="/", session=session)
-        await adguard.request("/")
-
-
-async def test_request_custom_user_agent(aresponses: ResponsesMockServer) -> None:
-    """Test AdGuard Home client sending correct user agent headers."""
-
-    # Handle to run asserts on request in
-    async def response_handler(request: aiohttp.ClientResponse) -> Response:
-        """Response handler for this test."""
-        assert request.headers["User-Agent"] == "LoremIpsum/1.0"
-        return aresponses.Response(text="TEDDYBEAR", status=200)
-
-    aresponses.add("example.com:3000", "/", "GET", response_handler)
-
-    async with aiohttp.ClientSession() as session:
-        adguard = AdGuardHome(
-            "example.com",
-            base_path="/",
-            session=session,
-            user_agent="LoremIpsum/1.0",
-        )
-        await adguard.request("/")
-
-
 async def test_timeout(aresponses: ResponsesMockServer) -> None:
     """Test request timeout from AdGuard Home."""