Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether ActiveRecord Association Proxy tests are still relevant #558

Open
floehopper opened this issue Sep 25, 2022 · 1 comment
Open

Investigate whether ActiveRecord Association Proxy tests are still relevant #558

floehopper opened this issue Sep 25, 2022 · 1 comment
Labels
quality

Comments

@floehopper
Copy link
Member

floehopper commented Sep 25, 2022 •
edited
Loading

I've just removed some of these in 46fca7a & 3b369e9, because they specifically related to Ruby v1.8 and we dropped support for that in ddb5d67.

Although the remaining tests reference Ruby v1.9, I suspect that really meant Ruby >= v1.9, i.e. not Ruby v1.8, because at the time these tests were added (705d9ba in 2008) Ruby v1.9 was probably the latest version!

It's moderately likely that the way ActiveRecord works has changed in the meantime, so it's worth checking whether these tests are still relevant.
@floehopper
Copy link
Member Author

Possibly a duplicate of #455

@floehopper floehopper mentioned this issue Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@floehopper