Test and fix put broadcast #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iduartgomez
reviewed
Jan 2, 2022
|
The PR is not compiling due to an import/dependency. |
netsirius
force-pushed
the
test-put-broadcast
branch
3 times, most recently
from
30780eb to
fab3d68
Compare
|
@iduartgomez I have resolved most of the comments. Could you check it out? |
iduartgomez
reviewed
Jan 4, 2022
|
The clippy and fmt checks should pass at least (there are a couple unit tests which are not fixed yet but we can ignore those for now). Rememebr to run |
netsirius
force-pushed
the
test-put-broadcast
branch
from
c89f0e8 to
35fed2a
Compare
iduartgomez
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and test the broadcasting after put operation
The put operation flow has been fixed and tested. Now the broadcast to the subscribing nodes is done correctly.
The flow would be the following:
