Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup PR-CI runner without access to shared team resources - for private runner #151

Open
pvoborni opened this issue Jan 24, 2018 · 3 comments
Labels
difficulty:normal groomed Issues already discussed by the dev team prio:med type:feature

Comments

@pvoborni
Copy link
Member

Currently, PR-CI runners use FedoraPeopleUpload subtask for artifact uploads.

Setup for this task is hardcoded in constants.py as:

FEDORAPEOPLE_KEY_PATH = '/root/.ssh/freeipa_pr_ci'
FEDORAPEOPLE_DIR = 'ipa-maint@fedorapeople.org:/srv/groups/freeipa/prci/{path}'
FEDORAPEOPLE_BASE_URL = 'https://fedorapeople.org/groups/freeipa/prci/'
FEDORAPEOPLE_JOBS_URL = urllib.parse.urljoin(FEDORAPEOPLE_BASE_URL, 'jobs/')

Making this part configurable will allow people without access to FreeIPA team's official freeipa_pr_ci private key use PR-CI for their private runners.

Thinking of it. If we change FedoraPeopleUpload class into, e.g., RsyncUpload and define what the remote location should support we might then configure the CI against any server.

@dhnunes
Copy link
Member

dhnunes commented Apr 24, 2019

Hy @pvoborni ,

I think this Issue is not more applicable due to implementation of AWS right?

Using S3, everything that the developer will need is to configure the S3 and DynamoDB properly to process the PR's and upload the artifacts.

@pvoborni
Copy link
Member Author

Private S3 solves that but creates a different problem - a need for S3 and bit of knowledge of its configuration. I would not completely dismiss the idea of own rsync server but I'm fine with closing the issue - doesn't seem worth to spend time on it right now.

@pvoborni
Copy link
Member Author

rsync upload existed in the project before S3 introduction. It was removed in 2693519

@f-trivino f-trivino added the groomed Issues already discussed by the dev team label May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:normal groomed Issues already discussed by the dev team prio:med type:feature
Projects
None yet
Development

No branches or pull requests

4 participants