Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release SecureDrop 1.5.0 #5368

Closed
18 tasks done
rmol opened this issue Jul 13, 2020 · 7 comments · Fixed by #5428
Closed
18 tasks done

Release SecureDrop 1.5.0 #5368

rmol opened this issue Jul 13, 2020 · 7 comments · Fixed by #5428
Milestone

Comments

@rmol
Copy link
Contributor

rmol commented Jul 13, 2020

This is a tracking issue for the release of SecureDrop 1.5.0

String and feature freeze: 2020-07-14
String comment period: 2020-07-14 to 2020-07-17
Translation period: 2020-07-18 to 2020-07-26
Pre-release announcement: 2020-07-21
Release date: 2020-07-28

Release manager: @rmol
Deputy release manager: @emkll
Localization manager: @kushaldas
Deputy localization manager: @zenmonkeykstop

SecureDrop maintainers and testers: As you QA 1.5.0, please report back your testing results as comments on this ticket. File GitHub issues for any problems found, tag them "QA: Release", and associate them with the 1.5.0 milestone for tracking (or ask a maintainer to do so).

Test debian packages will be posted on https://apt-test.freedom.press signed with the test key. An Ansible playbook testing the upgrade path is here.

QA Matrix for 1.5.0

Test Plan for 1.5.0

Prepare release candidate (1.5.0~rc1)

After each test, please update the QA matrix and post details for Basic Server Testing, Application Acceptance Testing and 1.5.0-specific testing below in comments to this ticket.

Final release

  • Ensure builder in release branch is updated and/or update builder image
  • Push signed tag
  • Build final Debian packages for 1.5.0 (and preserve build logs)
  • Commit package build logs to https://github.com/freedomofpress/build-logs
  • Upload Debian packages to apt QA server (including new tor packages)
  • Pre-Flight: Test install and upgrade (both cron-apt on Xenial, and Ansible on Xenial) of 1.5.0 works w/ prod repo debs, test updater logic in Tails
  • Flip apt QA server to prod status
  • merge the release branch changes to master and verify new docs build
  • Prepare and distribute release messaging

Post release

  • Create GitHub release object
  • Merge changelog back to develop
  • Update upgrade testing boxes
  • Update roadmap wiki page
@zenmonkeykstop
Copy link
Contributor

zenmonkeykstop commented Jul 20, 2020

QA plan

  • NUC5s
  • NUC7s
  • Mac Minis
  • 1U test servers

1.5.0 QA Checklist

For both upgrades and fresh installs, here is a list of functionality that requires testing. You can use this for copy/pasting into your QA report. Feel free to edit this message to update the plan as appropriate.

If you have submitted a QA report already for a 1.5.0 release candidate with successful basic server testing and application acceptance testing sections, then you can skip these sections in subsequent reports, unless otherwise indicated by the Release Manager. This is to ensure that you focus your QA effort on the 1.5.0-specific changes as well as changes since the previous release candidate.

Environment

  • Install target: Nuc5s
  • Tails version: 4.8
  • Test Scenario: cron-apt
  • SSH over Tor: yes
  • Onion service version: v2+v3
  • Release candidate: rc1
  • General notes:

Basic Server Testing

  • I can access both the source and journalist interfaces
  • I can SSH into both machines over Tor
  • AppArmor is loaded on app
    • 0 processes are running unconfined
  • AppArmor is loaded on mon
    • 0 processes are running unconfined
  • Both servers are running grsec kernels
  • iptables rules loaded
  • OSSEC emails begin to flow after install
  • OSSEC emails are decrypted to correct key and I am able to decrypt them
  • QA Matrix checks pass

Command Line User Generation

  • Can successfully add admin user and login

Administration

  • I have backed up and successfully restored the app server following the backup documentation
  • If doing upgrade testing, make a backup on 1.4.1 and restore this backup on 1.5.0
  • "Send Test OSSEC Alert" button in the journalist triggers an OSSEC alert and an email is sent
  • Can successfully add journalist account with HOTP authentication not tested

Application Acceptance Testing

Source Interface

Landing page base cases
  • JS warning bar does not appear when using Security Slider high
  • JS warning bar does appear when using Security Slider Low
First submission base cases
  • On generate page, refreshing codename produces a new 7-word codename
  • On submit page, empty submissions produce flashed message
  • On submit page, short message submitted successfully
  • On submit page, file greater than 500 MB produces "The connection was reset" in Tor Browser quickly before the entire file is uploaded
  • On submit page, file less than 500 MB submitted successfully
Returning source base cases
  • Nonexistent codename cannot log in
  • Empty codename cannot log in
  • Legitimate codename can log in
  • Returning user can view journalist replies - need to log into journalist interface to test

Journalist Interface

Login base cases
  • Can log in with 2FA tokens
  • incorrect password cannot log in
  • invalid 2fa token cannot log in
  • 2fa immediate reuse cannot log in
  • Journalist account with HOTP can log in not tested
Index base cases
  • Filter by codename works
  • Starring and unstarring works
  • Click select all selects all submissions
  • Selecting all and clicking "Download" works
Individual source page
  • You can submit a reply and a flashed message and new row appears
  • You cannot submit an empty reply
  • Clicking "Delete Source And Submissions" and the source and docs are deleted
  • You can click on a document and successfully decrypt using application private key

Basic Tails Testing

Updater GUI

After updating to this release candidate and running securedrop-admin tailsconfig

  • The Updater GUI appears on boot
  • Updating occurs without issue

1.5.0 release-specific changes

Version updates

  • Kernel version running is 4.14.188-grsec (#5359)
  • Tor version running is 0.4.3.6 (#5362)

securedrop-admin

v2 Onion service deprecation warning (#5370)
  • Run securedrop-admin sdconfig and verify the v2 deprecation
    message at the prompt to enable v2 Onion services.

Firewall

Firewall rules persistence (#5309)
  • Firewall rules should be restored on securedrop-admin install or after a reboot.
    - Log in to the app server.
    - Clear the firewall rules:
    - sudo iptables -P INPUT ACCEPT
    - sudo iptables -P OUTPUT ACCEPT
    - sudo iptables -P FORWARD ACCEPT
    - sudo iptables -F
    - sudo iptables -X
    - sudo iptables -S # to confirm the rules were purged
    - Reboot the app server.
    - Log in to the app server.
    - Run sudo iptables -S and confirm the rules are restored and correct.
    - Clear the firewall rules again.
    - Run securedrop-admin install on the admin workstation.
    - Log in to the app server.
    - Run sudo iptables -S and confirm the rules are restored and correct.

Web Application

v2 Onion service deprecation warning (#5366)
  • Confirm that logging into the journalist interface with v2 Onion
    services enabled produces a warning message at the top of the
    page.
  • Confirm that no warning appears when only v3 Onion services are
    enabled.
Handling of deleted journalist accounts (#5284, plus expected PR for #5378)
  • Confirm that you cannot create a journalist account with
    username "deleted":
    - Log in to the journalist interface as an admin.
    - Try to add a user with username "deleted". You should get an
    error saying "This username is invalid because it is reserved
    for internal use by the software."

  • Confirm that you cannot change the username of an existing
    journalist account to "deleted":
    - Log in to the journalist interface as an admin.
    - Try to change a journalist's username to "deleted". You should
    get an error saying "This username is invalid because it is
    reserved for internal use by the software."
    FAIL - admin can change both own and journalist's username to deleted

  • Confirm that an existing journalist account with username
    "deleted" is functional.
    - Use manage.py add-journalist to add an account with username
    tbdeleted.
    - Run sudo -u www-data bash.
    - Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set username = 'deleted' where username = 'tbdeleted';"
    - Log in to the journalist interface with the "deleted" account.

  • Confirm that you cannot log in to a journalist account with both
    username and UUID of "deleted".
    - Log in to the app server.
    - Run sudo -u www-data bash.
    - Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set uuid = 'deleted' where username = 'deleted';"
    - Try to log in to the "deleted" account. It should fail.

Improved warning when deleting sources (#5358)
  • Confirm that the warning dialog when deleting a source contains
    "Warning: If you do this, all files for the selected sources
    will be unrecoverable, and the sources will no longer be able to
    log in using their previous codename."
    - Log in to the journalist interface.
    - Select a source and click the Delete button.
    - Confirm that the dialog contains the expected text.
API handling of disconnected submissions and replies (#5345, #5351)

Run through this test last, as it involves manually corrupting your
database and store in a way that could affect later tests.

  • Confirm that both the get_all_replies and the get_all_submissions API endpoints gracefully handle objects with no corresponding source.
    - Log in to the app server.
    - Run sudo -u www-data bash.
    - Run cd /var/www/securedrop.
    - Run ./qa_loader.py --journalist-count 1 --source-count 1 --submissions-per-source 1 --replies-per-source 1 --source-reply-fraction 1
    - Run sqlite3 /var/lib/securedrop/db.sqlite.
    - Identify the source you just added, then delete it with e.g. delete from sources where id = 1;.
    - Back on the admin workstation:
    - Get an API token, e.g.: torify curl -X POST -H "Content-Type: application/json" --data '{"username":"journalist","passphrase":"correct horse battery staple profanity oil chewy","one_time_code":"123456"}' http://appserver.onion/api/v1/token
    - Put the returned token in the TOKEN environment variable, e.g. export TOKEN="eyJpYXQ..."
    - Retrieve all replies, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/replies
    - Retrieve all submissions, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/submissions
    - There should be no errors from any of the API calls.

Preflight

  • Ensure the builder image is up-to-date on release day

These tests should be performed the day of release prior to live debian packages on apt.freedom.press

Basic testing

  • Install or upgrade occurs without error
  • Source interface is available and version string indicates it is 1.5.0
  • A message can be successfully submitted

Tails

  • The updater GUI appears on boot
  • The update successfully occurs to 1.5.0
  • After reboot, updater GUI no longer appears

@zenmonkeykstop
Copy link
Contributor

zenmonkeykstop commented Jul 21, 2020

QA plan

  • NUC5s
  • NUC7s
  • Mac Minis
  • 1U test servers

1.5.0 QA Checklist

For both upgrades and fresh installs, here is a list of functionality that requires testing. You can use this for copy/pasting into your QA report. Feel free to edit this message to update the plan as appropriate.

If you have submitted a QA report already for a 1.5.0 release candidate with successful basic server testing and application acceptance testing sections, then you can skip these sections in subsequent reports, unless otherwise indicated by the Release Manager. This is to ensure that you focus your QA effort on the 1.5.0-specific changes as well as changes since the previous release candidate.

Environment

  • Install target: Dell r440/r620
  • Tails version: 4.8
  • Test Scenario: update
  • SSH over Tor: yes
  • Onion service version: v2+v3
  • Release candidate: rc2
  • General notes:

Basic Server Testing

  • I can access both the source and journalist interfaces
  • I can SSH into both machines over Tor
  • AppArmor is loaded on app
    • 0 processes are running unconfined
  • AppArmor is loaded on mon
    • 0 processes are running unconfined
  • Both servers are running grsec kernels
  • iptables rules loaded
  • OSSEC emails begin to flow after install
  • OSSEC emails are decrypted to correct key and I am able to decrypt them
  • QA Matrix checks pass

Command Line User Generation

  • x] Can successfully add admin user and login

Administration

  • I have backed up and successfully restored the app server following the backup documentation
  • If doing upgrade testing, make a backup on 1.4.1 and restore this backup on 1.5.0
  • "Send Test OSSEC Alert" button in the journalist triggers an OSSEC alert and an email is sent
  • Can successfully add journalist account with HOTP authentication NOT TESTED
### SKIPPED Application Acceptance Testing SKIPPED

Source Interface

Landing page base cases
  • JS warning bar does not appear when using Security Slider high
  • JS warning bar does appear when using Security Slider Low
First submission base cases
  • On generate page, refreshing codename produces a new 7-word codename
  • On submit page, empty submissions produce flashed message
  • On submit page, short message submitted successfully
  • On submit page, file greater than 500 MB produces "The connection was reset" in Tor Browser quickly before the entire file is uploaded
  • On submit page, file less than 500 MB submitted successfully
Returning source base cases
  • Nonexistent codename cannot log in
  • Empty codename cannot log in
  • Legitimate codename can log in
  • Returning user can view journalist replies - need to log into journalist interface to test

Journalist Interface

Login base cases
  • Can log in with 2FA tokens
  • incorrect password cannot log in
  • invalid 2fa token cannot log in
  • 2fa immediate reuse cannot log in
  • Journalist account with HOTP can log in
Index base cases
  • Filter by codename works
  • Starring and unstarring works
  • Click select all selects all submissions
  • Selecting all and clicking "Download" works
Individual source page
  • You can submit a reply and a flashed message and new row appears
  • You cannot submit an empty reply
  • Clicking "Delete Source And Submissions" and the source and docs are deleted
  • You can click on a document and successfully decrypt using application private key

Basic Tails Testing

Updater GUI

After updating to this release candidate and running securedrop-admin tailsconfig

  • The Updater GUI appears on boot
  • Updating occurs without issue

1.5.0 release-specific changes

Version updates

  • Kernel version running is 4.14.188-grsec (#5359)
  • Tor version running is 0.4.3.6 (#5362)

securedrop-admin

v2 Onion service deprecation warning (#5370)
  • Run securedrop-admin sdconfig and verify the v2 deprecation
    message at the prompt to enable v2 Onion services.

Firewall

Firewall rules persistence (#5309)

SKIPPED DUE TO CONCERN ABOUT BREAKING ACCESS TO REMOTE TEST H/W

  • Firewall rules should be restored on securedrop-admin install or after a reboot.
    - Log in to the app server.
    - Clear the firewall rules:
    - sudo iptables -P INPUT ACCEPT
    - sudo iptables -P OUTPUT ACCEPT
    - sudo iptables -P FORWARD ACCEPT
    - sudo iptables -F
    - sudo iptables -X
    - sudo iptables -S # to confirm the rules were purged
    - Reboot the app server.
    - Log in to the app server.
    - Run sudo iptables -S and confirm the rules are restored and correct.
    - Clear the firewall rules again.
    - Run securedrop-admin install on the admin workstation.
    - Log in to the app server.
    - Run sudo iptables -S and confirm the rules are restored and correct.

Web Application

v2 Onion service deprecation warning (#5366)
  • Confirm that logging into the journalist interface with v2 Onion
    services enabled produces a warning message at the top of the
    page.
  • Confirm that no warning appears when only v3 Onion services are
    enabled.
Handling of deleted journalist accounts (#5284, plus expected PR for #5378)
  • Confirm that you cannot create a journalist account with
    username "deleted":
    - Log in to the journalist interface as an admin.
    - Try to add a user with username "deleted". You should get an
    error saying "This username is invalid because it is reserved
    for internal use by the software."

  • Confirm that you cannot change the username of an existing
    journalist account to "deleted":
    - Log in to the journalist interface as an admin.
    - Try to change a journalist's username to "deleted". You should
    get an error saying "This username is invalid because it is
    reserved for internal use by the software."

  • Confirm that an existing journalist account with username
    "deleted" is functional.
    - Use manage.py add-journalist to add an account with username
    tbdeleted.
    - Run sudo -u www-data bash.
    - Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set username = 'deleted' where username = 'tbdeleted';"
    - Log in to the journalist interface with the "deleted" account.

  • Confirm that you cannot log in to a journalist account with both
    username and UUID of "deleted".
    - Log in to the app server.
    - Run sudo -u www-data bash.
    - Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set uuid = 'deleted' where username = 'deleted';"
    - Try to log in to the "deleted" account. It should fail.

Improved warning when deleting sources (#5358)
  • Confirm that the warning dialog when deleting a source contains
    "Warning: If you do this, all files for the selected sources
    will be unrecoverable, and the sources will no longer be able to
    log in using their previous codename."
    - Log in to the journalist interface.
    - Select a source and click the Delete button.
    - Confirm that the dialog contains the expected text.
API handling of disconnected submissions and replies (#5345, #5351)

Run through this test last, as it involves manually corrupting your
database and store in a way that could affect later tests.

  • Confirm that both the get_all_replies and the get_all_submissions API endpoints gracefully handle objects with no corresponding source.
    - Log in to the app server.
    - Run sudo -u www-data bash.
    - Run cd /var/www/securedrop.
    - Run ./qa_loader.py --journalist-count 1 --source-count 1 --submissions-per-source 1 --replies-per-source 1 --source-reply-fraction 1
    - Run sqlite3 /var/lib/securedrop/db.sqlite.
    - Identify the source you just added, then delete it with e.g. delete from sources where id = 1;.
    - Back on the admin workstation:
    - Get an API token, e.g.: torify curl -X POST -H "Content-Type: application/json" --data '{"username":"journalist","passphrase":"correct horse battery staple profanity oil chewy","one_time_code":"123456"}' http://appserver.onion/api/v1/token
    - Put the returned token in the TOKEN environment variable, e.g. export TOKEN="eyJpYXQ..."
    - Retrieve all replies, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/replies
    - Retrieve all submissions, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/submissions
    - There should be no errors from any of the API calls.

Preflight

  • Ensure the builder image is up-to-date on release day

These tests should be performed the day of release prior to live debian packages on apt.freedom.press

Basic testing

  • Install or upgrade occurs without error
  • Source interface is available and version string indicates it is 1.5.0
  • A message can be successfully submitted

Tails

  • The updater GUI appears on boot
  • The update successfully occurs to 1.5.0
  • After reboot, updater GUI no longer appears

@rocodes
Copy link
Contributor

rocodes commented Jul 22, 2020

[WIP]

Environment

  • Install target: NUC7i7DNHE
  • Tails version: 4.8
  • Test Scenario: clean install
  • SSH over Tor: yes
  • Onion service version: v2+v3
  • Release candidate: rc2
  • General notes:

Basic Server Testing

  • I can access both the source and journalist interfaces
  • I can SSH into both machines over Tor
  • AppArmor is loaded on app
    • 0 processes are running unconfined
  • AppArmor is loaded on mon
    • 0 processes are running unconfined
  • Both servers are running grsec kernels
  • iptables rules loaded
  • OSSEC emails begin to flow after install
  • OSSEC emails are decrypted to correct key and I am able to decrypt them
  • QA Matrix checks pass

Command Line User Generation

  • Can successfully add admin user and login

Administration

  • I have backed up and successfully restored the app server following the backup documentation
  • If doing upgrade testing, make a backup on 1.4.1 and restore this backup on 1.5.0
  • "Send Test OSSEC Alert" button in the journalist triggers an OSSEC alert and an email is sent
  • Can successfully add journalist account with HOTP authentication

Application Acceptance Testing

Source Interface

Landing page base cases
  • JS warning bar does not appear when using Security Slider high
  • JS warning bar does appear when using Security Slider Low
First submission base cases
  • On generate page, refreshing codename produces a new 7-word codename
  • On submit page, empty submissions produce flashed message
  • On submit page, short message submitted successfully
  • On submit page, file greater than 500 MB produces "The connection was reset" in Tor Browser quickly before the entire file is uploaded
  • On submit page, file less than 500 MB submitted successfully
Returning source base cases
  • Nonexistent codename cannot log in
  • Empty codename cannot log in
  • Legitimate codename can log in
  • Returning user can view journalist replies - need to log into journalist interface to test

Journalist Interface

Login base cases
  • Can log in with 2FA tokens
  • incorrect password cannot log in
  • invalid 2fa token cannot log in
  • 2fa immediate reuse cannot log in
  • Journalist account with HOTP can log in (TODO)
Index base cases
  • Filter by codename works
  • Starring and unstarring works
  • Click select all selects all submissions
  • Selecting all and clicking "Download" works
Individual source page
  • You can submit a reply and a flashed message and new row appears
  • You cannot submit an empty reply
  • Clicking "Delete Source And Submissions" and the source and docs are deleted
  • You can click on a document and successfully decrypt using application private key

Basic Tails Testing

Updater GUI

After updating to this release candidate and running securedrop-admin tailsconfig

  • The Updater GUI appears on boot
  • Updating occurs without issue (?)

1.5.0 release-specific changes

Version updates

  • Kernel version running is 4.14.188-grsec (#5359)
  • Tor version running is 0.4.3.6 (#5362)

securedrop-admin

v2 Onion service deprecation warning (#5370)
  • Run securedrop-admin sdconfig and verify the v2 deprecation message at the prompt to enable v2 Onion services.

Firewall

Firewall rules persistence (#5309)
  • Firewall rules should be restored on securedrop-admin install or after a reboot.
    • Log in to the app server.
    • Clear the firewall rules:
      • sudo iptables -P INPUT ACCEPT
      • sudo iptables -P OUTPUT ACCEPT
      • sudo iptables -P FORWARD ACCEPT
      • sudo iptables -F
      • sudo iptables -X
      • sudo iptables -S # to confirm the rules were purged
      • Reboot the app server.
    • Log in to the app server.
    • Run sudo iptables -S and confirm the rules are restored and correct.
    • Clear the firewall rules again.
    • Run securedrop-admin install on the admin workstation.
    • Log in to the app server.
    • Run sudo iptables -S and confirm the rules are restored and correct.

Web Application

v2 Onion service deprecation warning (#5366)
  • Confirm that logging into the journalist interface with v2 Onion services enabled produces a warning message at the top of the page.
  • Confirm that no warning appears when only v3 Onion services are enabled. Cannot confirm this. Have tried multiple times. STR: enable v2+v3 and install. Disable v2 in sdconfig, then run install and tailsconfig.
Handling of deleted journalist accounts (#5284, plus expected PR for #5378)
  • Confirm that you cannot create a journalist account with username "deleted":

    • Log in to the journalist interface as an admin.
    • Try to add a user with username "deleted". You should get an error saying "This username is invalid because it is reserved for internal use by the software."
    • Try to add a user with username "deleted" with manage.py add-admin and manage.py add-journalist. In both cases you should get an error saying "This username is invalid because it is reserved for internal use by the software."
  • Confirm that you cannot change the username of an existing journalist account to "deleted":

    • Log in to the journalist interface as an admin.
    • Try to change a journalist's username to "deleted". You should get an error saying "This username is invalid because it is reserved for internal use by the software."
  • Confirm that an existing journalist account with username "deleted" is functional:

    • Use manage.py add-journalist to add an account with username tbdeleted.
    • Run sudo -u www-data bash.
    • Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set username = 'deleted' where username = 'tbdeleted';"
    • Log in to the journalist interface with the "deleted" account.
  • Confirm that you cannot log in to a journalist account with both username and UUID of "deleted":

    • Log in to the app server.
    • Run sudo -u www-data bash.
    • Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set uuid = 'deleted' where username = 'deleted';"
    • Try to log in to the "deleted" account. It should fail.
Improved warning when deleting sources (#5358)
  • Confirm that the warning dialog when deleting a source contains "Warning: If you do this, all files for the selected sources will be unrecoverable, and the sources will no longer be able to log in using their previous codename.":
    • Log in to the journalist interface.
    • Select a source and click the Delete button.
    • Confirm that the dialog contains the expected text.
API handling of disconnected submissions and replies (#5345, #5351)

Run through this test last, as it involves manually corrupting your database and store in a way that could affect later tests.

  • Confirm that both the get_all_replies and the get_all_submissions API endpoints gracefully handle objects with no corresponding source:
    • Log in to the app server.
    • Run sudo -u www-data bash.
    • Run cd /var/www/securedrop.
    • Run ./qa_loader.py --journalist-count 1 --source-count 1 --submissions-per-source 1 --replies-per-source 1 --source-reply-fraction 1
    • Run sqlite3 /var/lib/securedrop/db.sqlite.
    • Identify the source you just added, then delete it with e.g. delete from sources where id = 1;.
    • Back on the admin workstation:
      • Get an API token, e.g.: torify curl -X POST -H "Content-Type: application/json" --data '{"username":"journalist","passphrase":"correct horse battery staple profanity oil chewy","one_time_code":"123456"}' http://appserver.onion/api/v1/token
      • Put the returned token in the TOKEN environment variable, e.g. export TOKEN="eyJpYXQ..."
      • Retrieve all replies, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/replies
      • Retrieve all submissions, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/submissions
      • There should be no errors from any of the API calls.

@rmol
Copy link
Contributor Author

rmol commented Jul 22, 2020

Environment

  • Install target: NUC7i5BNH
  • Tails version: 4.8
  • Test Scenario: cron-apt
  • SSH over Tor: yes
  • Onion service version: v2+v3
  • Release candidate: rc2
  • General notes:

Basic Server Testing

  • I can access both the source and journalist interfaces
  • I can SSH into both machines over Tor
  • AppArmor is loaded on app
    • 0 processes are running unconfined
  • AppArmor is loaded on mon
    • 0 processes are running unconfined
  • Both servers are running grsec kernels
  • iptables rules loaded
  • OSSEC emails begin to flow after install
  • OSSEC emails are decrypted to correct key and I am able to decrypt them
  • QA Matrix checks pass

Command Line User Generation

  • Can successfully add admin user and login

Administration

  • I have backed up and successfully restored the app server following the backup documentation
  • If doing upgrade testing, make a backup on 1.4.1 and restore this backup on 1.5.0
  • "Send Test OSSEC Alert" button in the journalist triggers an OSSEC alert and an email is sent
  • Can successfully add journalist account with HOTP authentication

Application Acceptance Testing

Source Interface

Landing page base cases
  • JS warning bar does not appear when using Security Slider high
  • JS warning bar does appear when using Security Slider Low
First submission base cases
  • On generate page, refreshing codename produces a new 7-word codename
  • On submit page, empty submissions produce flashed message
  • On submit page, short message submitted successfully
  • On submit page, file greater than 500 MB produces "The connection was reset" in Tor Browser quickly before the entire file is uploaded
  • On submit page, file less than 500 MB submitted successfully
Returning source base cases
  • Nonexistent codename cannot log in
  • Empty codename cannot log in
  • Legitimate codename can log in
  • Returning user can view journalist replies - need to log into journalist interface to test

Journalist Interface

Login base cases
  • Can log in with 2FA tokens
  • incorrect password cannot log in
  • invalid 2fa token cannot log in
  • 2fa immediate reuse cannot log in
  • Journalist account with HOTP can log in
Index base cases
  • Filter by codename works
  • Starring and unstarring works
  • Click select all selects all submissions
  • Selecting all and clicking "Download" works
Individual source page
  • You can submit a reply and a flashed message and new row appears
  • You cannot submit an empty reply
  • Clicking "Delete Source And Submissions" and the source and docs are deleted
  • You can click on a document and successfully decrypt using application private key

Basic Tails Testing

Updater GUI

After updating to this release candidate and running securedrop-admin tailsconfig

  • The Updater GUI appears on boot
  • Updating occurs without issue

1.5.0 release-specific changes

Version updates

  • Kernel version running is 4.14.188-grsec (#5359)
  • Tor version running is 0.4.3.6 (#5362)

securedrop-admin

v2 Onion service deprecation warning (#5370)
  • Run securedrop-admin sdconfig and verify the v2 deprecation message at the prompt to enable v2 Onion services.

Firewall

Firewall rules persistence (#5309)
  • Firewall rules should be restored on securedrop-admin install or after a reboot.
    • Log in to the app server.
    • Clear the firewall rules:
      • sudo iptables -P INPUT ACCEPT
      • sudo iptables -P OUTPUT ACCEPT
      • sudo iptables -P FORWARD ACCEPT
      • sudo iptables -F
      • sudo iptables -X
      • sudo iptables -S # to confirm the rules were purged
      • Reboot the app server.
    • Log in to the app server.
    • Run sudo iptables -S and confirm the rules are restored and correct.
    • Clear the firewall rules again.
    • Run securedrop-admin install on the admin workstation.
    • Log in to the app server.
    • Run sudo iptables -S and confirm the rules are restored and correct.

Web Application

v2 Onion service deprecation warning (#5366)
  • Confirm that logging into the journalist interface with v2 Onion services enabled produces a warning message at the top of the page.
  • Confirm that no warning appears when only v3 Onion services are enabled.
Handling of deleted journalist accounts (#5284, #5380)
  • Confirm that you cannot create a journalist account with username "deleted":

    • Log in to the journalist interface as an admin.
    • Try to add a user with username "deleted". You should get an error saying "This username is invalid because it is reserved for internal use by the software."
    • Try to add a user with username "deleted" with manage.py add-admin and manage.py add-journalist. In both cases you should get an error saying "This username is invalid because it is reserved for internal use by the software."
  • Confirm that you cannot change the username of an existing journalist account to "deleted":

    • Log in to the journalist interface as an admin.
    • Try to change a journalist's username to "deleted". You should get an error saying "This username is invalid because it is reserved for internal use by the software."
  • Confirm that an existing journalist account with username "deleted" is functional:

    • Use manage.py add-journalist to add an account with username tbdeleted.
    • Run sudo -u www-data bash.
    • Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set username = 'deleted' where username = 'tbdeleted';"
    • Log in to the journalist interface with the "deleted" account.
  • Confirm that you cannot log in to a journalist account with both username and UUID of "deleted":

    • Log in to the app server.
    • Run sudo -u www-data bash.
    • Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set uuid = 'deleted' where username = 'deleted';"
    • Try to log in to the "deleted" account. It should fail.
Improved warning when deleting sources (#5358)
  • Confirm that the warning dialog when deleting a source contains "Warning: If you do this, all files for the selected sources will be unrecoverable, and the sources will no longer be able to log in using their previous codename.":
    • Log in to the journalist interface.
    • Select a source and click the Delete button.
    • Confirm that the dialog contains the expected text.
API handling of disconnected submissions and replies (#5345, #5351)

Run through this test last, as it involves manually corrupting your database and store in a way that could affect later tests.

  • Confirm that both the get_all_replies and the get_all_submissions API endpoints gracefully handle objects with no corresponding source:
    • Log in to the app server.
    • Run sudo -u www-data bash.
    • Run cd /var/www/securedrop.
    • Run ./qa_loader.py --journalist-count 1 --source-count 1 --submissions-per-source 1 --replies-per-source 1 --source-reply-fraction 1
    • Run sqlite3 /var/lib/securedrop/db.sqlite.
    • Identify the source you just added, then delete it with e.g. delete from sources where id = 1;.
    • Back on the admin workstation:
      • Get an API token, e.g.: torify curl -X POST -H "Content-Type: application/json" --data '{"username":"journalist","passphrase":"correct horse battery staple profanity oil chewy","one_time_code":"123456"}' http://appserver.onion/api/v1/token
      • Put the returned token in the TOKEN environment variable, e.g. export TOKEN="eyJpYXQ..."
      • Retrieve all replies, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/replies
      • Retrieve all submissions, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/submissions
      • There should be no errors from any of the API calls.

@zenmonkeykstop
Copy link
Contributor

Environment

  • Install target: nuc5s
  • Tails version: 4.8
  • Test Scenario: cron-apt
  • SSH over Tor: yes
  • Onion service version: v2+v3
  • Release candidate: 1.5.0-rc2
  • General notes: (cron-apt happened automatically overnight, as test hardware was already using apt-test repo)

Basic Server Testing

  • I can access both the source and journalist interfaces
  • I can SSH into both machines over Tor
  • AppArmor is loaded on app
    • 0 processes are running unconfined
  • AppArmor is loaded on mon
    • 0 processes are running unconfined
  • Both servers are running grsec kernels
  • iptables rules loaded
  • OSSEC emails begin to flow after install
  • OSSEC emails are decrypted to correct key and I am able to decrypt them
  • QA Matrix checks pass

Command Line User Generation

  • Can successfully add admin user and login

Administration

  • I have backed up and successfully restored the app server following the backup documentation
  • If doing upgrade testing, make a backup on 1.4.1 and restore this backup on 1.5.0
  • "Send Test OSSEC Alert" button in the journalist triggers an OSSEC alert and an email is sent
  • Can successfully add journalist account with HOTP authentication

Application Acceptance Testing

Source Interface

Landing page base cases
  • JS warning bar does not appear when using Security Slider high
  • JS warning bar does appear when using Security Slider Low
First submission base cases
  • On generate page, refreshing codename produces a new 7-word codename
  • On submit page, empty submissions produce flashed message
  • On submit page, short message submitted successfully
  • On submit page, file greater than 500 MB produces "The connection was reset" in Tor Browser quickly before the entire file is uploaded
  • On submit page, file less than 500 MB submitted successfully
Returning source base cases
  • Nonexistent codename cannot log in
  • Empty codename cannot log in
  • Legitimate codename can log in
  • Returning user can view journalist replies - need to log into journalist interface to test

Journalist Interface

Login base cases
  • Can log in with 2FA tokens
  • incorrect password cannot log in
  • invalid 2fa token cannot log in
  • 2fa immediate reuse cannot log in
  • Journalist account with HOTP can log in
Index base cases
  • Filter by codename works
  • Starring and unstarring works
  • Click select all selects all submissions
  • Selecting all and clicking "Download" works
Individual source page
  • You can submit a reply and a flashed message and new row appears
  • You cannot submit an empty reply
  • Clicking "Delete Source And Submissions" and the source and docs are deleted
  • You can click on a document and successfully decrypt using application private key

Basic Tails Testing

Updater GUI

After updating to this release candidate and running securedrop-admin tailsconfig

  • The Updater GUI appears on boot
  • Updating occurs without issue

1.5.0 release-specific changes

Version updates

  • Kernel version running is 4.14.188-grsec (#5359)
  • Tor version running is 0.4.3.6 (#5362)

securedrop-admin

v2 Onion service deprecation warning (#5370)
  • Run securedrop-admin sdconfig and verify the v2 deprecation message at the prompt to enable v2 Onion services.

Firewall

Firewall rules persistence (#5309)
  • Firewall rules should be restored on securedrop-admin install or after a reboot.
    • Log in to the app server.
    • Clear the firewall rules:
      • sudo iptables -P INPUT ACCEPT
      • sudo iptables -P OUTPUT ACCEPT
      • sudo iptables -P FORWARD ACCEPT
      • sudo iptables -F
      • sudo iptables -X
      • sudo iptables -S # to confirm the rules were purged
      • Reboot the app server.
    • Log in to the app server.
    • Run sudo iptables -S and confirm the rules are restored and correct.
    • Clear the firewall rules again.
    • Run securedrop-admin install on the admin workstation.
    • Log in to the app server.
    • Run sudo iptables -S and confirm the rules are restored and correct.

Web Application

v2 Onion service deprecation warning (#5366)
  • Confirm that logging into the journalist interface with v2 Onion services enabled produces a warning message at the top of the page.
  • Confirm that no warning appears when only v3 Onion services are enabled.
Handling of deleted journalist accounts (#5284, #5380)
  • Confirm that you cannot create a journalist account with username "deleted":

    • Log in to the journalist interface as an admin.
    • Try to add a user with username "deleted". You should get an error saying "This username is invalid because it is reserved for internal use by the software."
    • Try to add a user with username "deleted" with manage.py add-admin and manage.py add-journalist. In both cases you should get an error saying "This username is invalid because it is reserved for internal use by the software."
  • Confirm that you cannot change the username of an existing journalist account to "deleted":

    • Log in to the journalist interface as an admin.
    • Try to change a journalist's username to "deleted". You should get an error saying "This username is invalid because it is reserved for internal use by the software."
  • Confirm that an existing journalist account with username "deleted" is functional:

    • Use manage.py add-journalist to add an account with username tbdeleted.
    • Run sudo -u www-data bash.
    • Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set username = 'deleted' where username = 'tbdeleted';"
    • Log in to the journalist interface with the "deleted" account.
  • Confirm that you cannot log in to a journalist account with both username and UUID of "deleted":

    • Log in to the app server.
    • Run sudo -u www-data bash.
    • Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set uuid = 'deleted' where username = 'deleted';"
    • Try to log in to the "deleted" account. It should fail.
Improved warning when deleting sources (#5358)
  • Confirm that the warning dialog when deleting a source contains "Warning: If you do this, all files for the selected sources will be unrecoverable, and the sources will no longer be able to log in using their previous codename.":
    • Log in to the journalist interface.
    • Select a source and click the Delete button.
    • Confirm that the dialog contains the expected text.
API handling of disconnected submissions and replies (#5345, #5351)

Run through this test last, as it involves manually corrupting your database and store in a way that could affect later tests.

  • Confirm that both the get_all_replies and the get_all_submissions API endpoints gracefully handle objects with no corresponding source:
    • Log in to the app server.
    • Run sudo -u www-data bash.
    • Run cd /var/www/securedrop.
    • Run ./qa_loader.py --journalist-count 1 --source-count 1 --submissions-per-source 1 --replies-per-source 1 --source-reply-fraction 1
    • Run sqlite3 /var/lib/securedrop/db.sqlite.
    • Identify the source you just added, then delete it with e.g. delete from sources where id = 1;.
    • Back on the admin workstation:
      • Get an API token, e.g.: torify curl -X POST -H "Content-Type: application/json" --data '{"username":"journalist","passphrase":"correct horse battery staple profanity oil chewy","one_time_code":"123456"}' http://appserver.onion/api/v1/token
      • Put the returned token in the TOKEN environment variable, e.g. export TOKEN="eyJpYXQ..."
      • Retrieve all replies, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/replies
      • Retrieve all submissions, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/submissions
      • There should be no errors from any of the API calls.

Preflight

  • Ensure the builder image is up-to-date on release day

These tests should be performed the day of release prior to live debian packages on apt.freedom.press

Basic testing

  • Install or upgrade occurs without error
  • Source interface is available and version string indicates it is 1.5.0
  • A message can be successfully submitted

Tails

  • The updater GUI appears on boot
  • The update successfully occurs to 1.5.0
  • After reboot, updater GUI no longer appears

@emkll
Copy link
Contributor

emkll commented Jul 23, 2020

Environment

  • Install target: Mac mini (App server) NUC5PYH (mon server)
  • Tails version: 4.8
  • Test Scenario: Cron-apt update (v3 only)
  • SSH over Tor: yes
  • Onion service version: v3
  • Release candidate: 1.5.0-rc2
  • General notes:

Basic Server Testing

  • I can access both the source and journalist interfaces
  • I can SSH into both machines over Tor
  • AppArmor is loaded on app
    • 0 processes are running unconfined
  • AppArmor is loaded on mon
    • 0 processes are running unconfined
  • Both servers are running grsec kernels
  • iptables rules loaded
  • OSSEC emails begin to flow after install
  • OSSEC emails are decrypted to correct key and I am able to decrypt them
  • QA Matrix checks pass

Command Line User Generation

  • Can successfully add admin user and login

Administration

Application Acceptance Testing

Source Interface

Landing page base cases
  • JS warning bar does not appear when using Security Slider high
  • JS warning bar does appear when using Security Slider Low
First submission base cases
  • On generate page, refreshing codename produces a new 7-word codename
  • On submit page, empty submissions produce flashed message
  • On submit page, short message submitted successfully
  • On submit page, file greater than 500 MB produces "The connection was reset" in Tor Browser quickly before the entire file is uploaded
  • On submit page, file less than 500 MB submitted successfully
Returning source base cases
  • Nonexistent codename cannot log in
  • Empty codename cannot log in
  • Legitimate codename can log in
  • Returning user can view journalist replies - need to log into journalist interface to test

Journalist Interface

Login base cases
  • Can log in with 2FA tokens
  • incorrect password cannot log in
  • invalid 2fa token cannot log in
  • 2fa immediate reuse cannot log in
  • Journalist account with HOTP can log in
Index base cases
  • Filter by codename works
  • Starring and unstarring works
  • Click select all selects all submissions
  • Selecting all and clicking "Download" works
Individual source page
  • You can submit a reply and a flashed message and new row appears
  • You cannot submit an empty reply
  • Clicking "Delete Source And Submissions" and the source and docs are deleted
  • You can click on a document and successfully decrypt using application private key

Basic Tails Testing

Updater GUI

After updating to this release candidate and running securedrop-admin tailsconfig

  • The Updater GUI appears on boot
  • Updating occurs without issue

1.5.0 release-specific changes

Version updates

  • Kernel version running is 4.14.188-grsec (#5359)
  • Tor version running is 0.4.3.6 (#5362)

securedrop-admin

v2 Onion service deprecation warning (#5370)
  • Run securedrop-admin sdconfig and verify the v2 deprecation message at the prompt to enable v2 Onion services. (DID NOT TEST, v3-only scenario)

Firewall

Firewall rules persistence (#5309)
  • Firewall rules should be restored on securedrop-admin install or after a reboot.
    • Log in to the app server.
    • Clear the firewall rules:
      • sudo iptables -P INPUT ACCEPT
      • sudo iptables -P OUTPUT ACCEPT
      • sudo iptables -P FORWARD ACCEPT
      • sudo iptables -F
      • sudo iptables -X
      • sudo iptables -S # to confirm the rules were purged
      • Reboot the app server.
    • Log in to the app server.
    • Run sudo iptables -S and confirm the rules are restored and correct.
    • Clear the firewall rules again.
    • Run securedrop-admin install on the admin workstation.
    • Log in to the app server.
    • Run sudo iptables -S and confirm the rules are restored and correct.

Web Application

v2 Onion service deprecation warning (#5366)
  • Confirm that logging into the journalist interface with v2 Onion services enabled produces a warning message at the top of the page.
  • Confirm that no warning appears when only v3 Onion services are enabled.
Handling of deleted journalist accounts (#5284, #5380)
  • Confirm that you cannot create a journalist account with username "deleted":

    • Log in to the journalist interface as an admin.
    • Try to add a user with username "deleted". You should get an error saying "This username is invalid because it is reserved for internal use by the software."
    • Try to add a user with username "deleted" with manage.py add-admin and manage.py add-journalist. In both cases you should get an error saying "This username is invalid because it is reserved for internal use by the software."
  • Confirm that you cannot change the username of an existing journalist account to "deleted":

    • Log in to the journalist interface as an admin.
    • Try to change a journalist's username to "deleted". You should get an error saying "This username is invalid because it is reserved for internal use by the software."
  • Confirm that an existing journalist account with username "deleted" is functional:

    • Use manage.py add-journalist to add an account with username tbdeleted.
    • Run sudo -u www-data bash.
    • Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set username = 'deleted' where username = 'tbdeleted';"
    • Log in to the journalist interface with the "deleted" account.
  • Confirm that you cannot log in to a journalist account with both username and UUID of "deleted":

    • Log in to the app server.
    • Run sudo -u www-data bash.
    • Run sqlite3 /var/lib/securedrop/db.sqlite "update journalists set uuid = 'deleted' where username = 'deleted';"
    • Try to log in to the "deleted" account. It should fail.
Improved warning when deleting sources (#5358)
  • Confirm that the warning dialog when deleting a source contains "Warning: If you do this, all files for the selected sources will be unrecoverable, and the sources will no longer be able to log in using their previous codename.":
    • Log in to the journalist interface.
    • Select a source and click the Delete button.
    • Confirm that the dialog contains the expected text.
API handling of disconnected submissions and replies (#5345, #5351)

Run through this test last, as it involves manually corrupting your database and store in a way that could affect later tests.

  • Confirm that both the get_all_replies and the get_all_submissions API endpoints gracefully handle objects with no corresponding source:
    • Log in to the app server.
    • Run sudo -u www-data bash.
    • Run cd /var/www/securedrop.
    • Run ./qa_loader.py --journalist-count 1 --source-count 1 --submissions-per-source 1 --replies-per-source 1 --source-reply-fraction 1
    • Run sqlite3 /var/lib/securedrop/db.sqlite.
    • Identify the source you just added, then delete it with e.g. delete from sources where id = 1;.
    • Back on the admin workstation:
      • Get an API token, e.g.: torify curl -X POST -H "Content-Type: application/json" --data '{"username":"journalist","passphrase":"correct horse battery staple profanity oil chewy","one_time_code":"123456"}' http://appserver.onion/api/v1/token
      • Put the returned token in the TOKEN environment variable, e.g. export TOKEN="eyJpYXQ..."
      • Retrieve all replies, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/replies
      • Retrieve all submissions, e.g.: torify curl -X GET -H "Content-Type: application/json" -H "Authorization: Token $TOKEN" http://appserver.onion/api/v1/submissions
      • There should be no errors from any of the API calls.

Preflight

  • Ensure the builder image is up-to-date on release day

These tests should be performed the day of release prior to live debian packages on apt.freedom.press

Basic testing

  • Install or upgrade occurs without error
  • Source interface is available and version string indicates it is 1.5.0
  • A message can be successfully submitted

Tails

  • The updater GUI appears on boot
  • The update successfully occurs to 1.5.0
  • After reboot, updater GUI no longer appears

@kushaldas
Copy link
Contributor

Tested #5366 on 1.5.0-rc3, works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants