Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During 14.04->16.04 upgrade, tmux is unable to re-attach #4221

Closed
eloquence opened this issue Mar 4, 2019 · 4 comments · Fixed by #4231
Closed

During 14.04->16.04 upgrade, tmux is unable to re-attach #4221

eloquence opened this issue Mar 4, 2019 · 4 comments · Fixed by #4231
Milestone

Comments

@eloquence
Copy link
Member

An organization performing a Xenial upgrade reported that they were unable to re-attach to the Application Server after the sshd restart. They attributed this to the fact that tmux itself was upgraded before then. They were able to manually re-attach by finding the old process ID via pgrep and re-attaching via /proc/$pid/exe.

They did not experience the same issue upgrading the Monitor Server.

We should attempt to understand the root cause and, if warranted, add an update to the documentation to help users work around this issue.

@eloquence eloquence changed the title During 14.04->16.04 upgrade, tmux be unable to re-attach During 14.04->16.04 upgrade, tmux is unable to re-attach Mar 5, 2019
@rmol
Copy link
Contributor

rmol commented Mar 5, 2019

I've reproduced this. Happened exactly as described -- only on the app server, where attaching via the old executable under /proc worked. I've got a fix -- basically incorporating their workaround by adding to /etc/profile.d/bashrc_securedrop_additions an attempt to attach via the /proc copy of the old executable if attaching fails but a session is found -- but want to go through another test cycle or two to validate it.

@eloquence eloquence added this to the 0.12.1 milestone Mar 5, 2019
@eloquence
Copy link
Member Author

eloquence commented Mar 5, 2019

Thanks for the repro! This seems like a good candidate for the point release, so tentatively added to the milestone. That said, if we're certain this will impact prod upgrades, we should update the docs with the workaround before then.

@kushaldas
Copy link
Contributor

Is this over tor or direct ssh also? Asking because I never had this trouble in direct ssh connections.

@rmol
Copy link
Contributor

rmol commented Mar 5, 2019

The problem did not occur with direct SSH connections to the servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants