-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve flashed message when source successfully submits a document or message #1525
Comments
Thanks for posting, @redshiftzero! I'm not a developer, so for whomever chooses to code this—my notes, below. Thank you! :) Implementation notes:
Ok! Icon SVG: |
@ninavizz I don't think I can get the organisation name to insert into this flash message, as it's not currently declared by the organisation anywhere (that I could find at least!). Is there alternate text that would work here instead? |
@jcmcreate The alternative would be "Thank you for sharing this information with us!" @fowlslegs @justintroutman @redshiftzero This ain't urgent, but generally speaking SD needs to be able to message users with the name of the newsroom in the messaging. Could it be prioritized to include the org name as a declaration upon installation (did I word that correctly?)? |
@jcmcreate There are steps in the if config.org_name:
flash('Thanks for submitting to {}!'.format(config.org_name), 'notification')
else:
flash('Thanks for submitting to us!', 'notification') And yes, I think it makes sense to make the split into two distinct messages to future proof it from strange grammar errors. |
^ re: Freddy's observation... any chance this has since been fixed? |
Nobody responded to my prior question, so I'll try another poke... anyone know if the issue Freddy brought light to in October 2017 is still an accurate reflection of a Source's multi-file upload experience, today? This issue imho should be closed @eloquence (as the OG bit it was created for was implemented some time ago), and Freddy's comment carried-over into a new issue. |
Take on to close issue in #4967. Macro issue however, remains around single-file-upload as confusing user problem. |
As noted above, this original design suggestion was implemented; closing. |
This is a UX suggestion by @ninavizz to improve the notification displayed to sources upon submission of a document or message (click on image below to see her suggestion for this issue in greater detail):
The text was updated successfully, but these errors were encountered: