-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Read/Unread to Include Files Status #39
Comments
Ok! Here's a first-stab with a few different versions. Both show options for how using those parts of the screen could scale to support "Seen By" functionality. I can haz feedbacks @redshiftzero @eloquence @creviera? https://drive.google.com/open?id=1BF40zsK5zfoKmqCrTafQCIu-Lw4fw8cV Tangential notes wrt shown mockups:
|
BTW, Slack's patterns wrt this: |
@eloquence The checkmark direction is what we'd decided upon, correct? Do you want to do any more design-y work on this before I hand off to Allie to implement? @redshiftzero also piped-up in support of the checkmark direction |
Yep!
Implementation is still blocked on the server-side spec, but I think this is fine to add to freedomofpress/securedrop-client#187. Note that there's currently a wireframe in that issue demonstrating the Source List "new/not new" indicators (bold formatting of source designations); it might be nice to have a single combined image that shows both a "seen file" and a "new source" in the source list. If we use a version with the briefcase iconography in the issue, it's also worth noting explicitly that it's separate from and unrelated to the seen/unseen/new functionality. |
Aye aye @eloquence! Taking a page from the Erik book, tho, I'll still then close this Issue as it's now been deemed complete w/in its determined scope. Final art for the icon, I'll plop into securedrop-client/#187. It's also linked-out to from #17, here. Also, fwiw, I'm trying to track all content for the client (icons, images, text) in #17. I've created a table in that Issue for icons, so you/Allie can track what's up with each item's status. Until all VisDe is wrapped & as new things arise, it'll be tough to deliver wireframes and/or animations with 100% final attributes from corner to corner. p.s.: if my attempts at "being organized" just add more chaos than order, pls to let me know! order is teh goal. |
Problem
When a journalist clicks on a Source when a new file, message, or both, have come-in, the view of that source in the list changes states from "Unread" (bolded/black) to "Read" (un-bolded/gray).
It has been decided that it will be useful to similarly mark files after they have been downloaded, and opened in a Disposable VM. This Issue is to demonstrate that implemented design and behavior.
Discussion about potentially delaying that "marking" of the file as Read until the user elects to close the Disp-VM did happen; validating the potential usefulness of the added dev complexity for that, in Pilot research, was determined as an appropriate handling of that escalation. For now, we'll keep it simple and simply add the marker once the user-acted-upon downloaded file has successfully opened in its Disp-VM.
Considerations
Acceptance Criteria
This is a sub-task within #18 and #31 and #17
The text was updated successfully, but these errors were encountered: