Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out usage of sync_flag file #1255

Open
sssoleileraaa opened this issue Apr 29, 2021 · 0 comments
Open

Phase out usage of sync_flag file #1255

sssoleileraaa opened this issue Apr 29, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sssoleileraaa
Copy link
Contributor

Description

During sync, a file called sync_flag is created in the ~/.securedrop_client directory on sd-app in order to track timestamps for each metadata sync. To clean up files the client creates on the fs, we could instead track these in svs.sqlite.

It also might be a good time to reconsider the trade-offs for tracking last-sync timestamps between client instances. Right now, if you log on in offline mode, you can see the last time you synced with the server because we record these timestamps. If we wanted to minimize the data we store in the sd-app db, we could instead show the last-sync timestamps only within a single instance by tracking last-sync in-memory only.

@eloquence eloquence added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants